From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbdJPJ3S (ORCPT ); Mon, 16 Oct 2017 05:29:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49232 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdJPJ3R (ORCPT ); Mon, 16 Oct 2017 05:29:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8139B356EA Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 16 Oct 2017 11:28:53 +0200 From: Jiri Olsa To: "Du, Changbin" Cc: Arnaldo Carvalho de Melo , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, jolsa@kernel.org Subject: Re: Does perf-annotate work correctly? Message-ID: <20171016092853.GA31858@krava> References: <20170912101035.GA21638@intel.com> <20170912143350.GA3452@kernel.org> <20170913091408.GA9625@intel.com> <20171013101500.GA29995@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171013101500.GA29995@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 16 Oct 2017 09:29:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2017 at 06:15:00PM +0800, Du, Changbin wrote: > Hi Jiri, > Sorry, missed you (but get_maintainer.pl doesn't list you). Here is ealier email. > https://lkml.org/lkml/2017/9/12/158 > > Do you think if this is a real issue? SNIP > > 0.02 │ test %esi,%esi ▒ > > │ ↓ js 25 ▒ > > 99.98 │ ← retq ▒ > > │25: push %rbp ▒ > > │ mov $0x440a,%ecx ▒ > > │ mov $0x440c,%edx ▒ > > │ vmx_complete_interrupts(): ◆ > > │ break; ▒ > > │ } ▒ > > │ } ▒ > > │ ▒ > > │ static void vmx_complete_interrupts(struct vcpu_vmx *vmx) ▒ > > │ { ▒ > > │ mov %rsp,%rbp ▒ > > │ → callq __vmx_complete_interrupts.part.64 ▒ > > │ __vmx_complete_interrupts(&vmx->vcpu, vmx->idt_vectoring_info, ▒ > > │ pop %rbp ▒ > > │ ← retq ▒ hi, there's 'o' key to togle the instruction address or you can use the perf annotate --stdio to get it.. should be easier to tell if that's the same instruction jirka