From: "Du, Changbin" <changbin.du@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Du, Changbin" <changbin.du@intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
jolsa@kernel.org
Subject: Re: Does perf-annotate work correctly?
Date: Mon, 16 Oct 2017 17:34:40 +0800 [thread overview]
Message-ID: <20171016093439.GA10280@intel.com> (raw)
In-Reply-To: <20171016092853.GA31858@krava>
[-- Attachment #1: Type: text/plain, Size: 2718 bytes --]
On Mon, Oct 16, 2017 at 11:28:53AM +0200, Jiri Olsa wrote:
> On Fri, Oct 13, 2017 at 06:15:00PM +0800, Du, Changbin wrote:
> > Hi Jiri,
> > Sorry, missed you (but get_maintainer.pl doesn't list you). Here is ealier email.
> > https://lkml.org/lkml/2017/9/12/158
> >
> > Do you think if this is a real issue?
>
> SNIP
>
> > > 0.02 │ test %esi,%esi ▒
> > > │ ↓ js 25 ▒
> > > 99.98 │ ← retq ▒
> > > │25: push %rbp ▒
> > > │ mov $0x440a,%ecx ▒
> > > │ mov $0x440c,%edx ▒
> > > │ vmx_complete_interrupts(): ◆
> > > │ break; ▒
> > > │ } ▒
> > > │ } ▒
> > > │ ▒
> > > │ static void vmx_complete_interrupts(struct vcpu_vmx *vmx) ▒
> > > │ { ▒
> > > │ mov %rsp,%rbp ▒
> > > │ → callq __vmx_complete_interrupts.part.64 ▒
> > > │ __vmx_complete_interrupts(&vmx->vcpu, vmx->idt_vectoring_info, ▒
> > > │ pop %rbp ▒
> > > │ ← retq ▒
>
> hi,
> there's 'o' key to togle the instruction address or you
> can use the perf annotate --stdio to get it.. should be
> easier to tell if that's the same instruction
>
Thanks for replying. I know the reason now, the instructions are shown in pc
address order, and some C statments are split into chunks. It gives me a
illusion. Thanks.
> jirka
>
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-10-16 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 10:10 Does perf-annotate work correctly? Du, Changbin
2017-09-12 14:33 ` Arnaldo Carvalho de Melo
2017-09-13 1:54 ` Du, Changbin
2017-09-26 6:06 ` Du, Changbin
2017-09-13 9:14 ` Du, Changbin
2017-10-13 10:15 ` Du, Changbin
2017-10-16 9:28 ` Jiri Olsa
2017-10-16 9:34 ` Du, Changbin [this message]
2017-10-16 9:30 ` Jiri Olsa
2017-10-16 9:35 ` Du, Changbin
2017-10-16 10:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016093439.GA10280@intel.com \
--to=changbin.du@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).