From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755628AbdJPQoN (ORCPT ); Mon, 16 Oct 2017 12:44:13 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46740 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755229AbdJPQoL (ORCPT ); Mon, 16 Oct 2017 12:44:11 -0400 Date: Mon, 16 Oct 2017 18:44:03 +0200 From: Andrew Lunn To: David Laight Cc: Rodney Cummings , Vivien Didelot , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@savoirfairelinux.com" , "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr Message-ID: <20171016164403.GC13339@lunn.ch> References: <20171013181809.14627-1-vivien.didelot@savoirfairelinux.com> <20171016160941.GA13339@lunn.ch> <063D6719AE5E284EB5DD2968C1650D6DD00980E8@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD00980E8@AcuExch.aculab.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 04:30:34PM +0000, David Laight wrote: > From: Andrew Lunn > > Sent: 16 October 2017 17:10 > ... > > So, received Pause frames never leave the MAC. They don't get bridged, > > nor do they get passed up for host processing. They are purely point > > to point between two MAC peers. The destination is unambiguous. It is > > simple the other MAC peer. The destination address makes it clear it > > is a pause frame, the the source address seems to be unneeded. > > > > In this context, a random MAC addresses are safe. > > Is there any reason why a fixed value (say 00:00:00:00:00:00) > can't be used? I was going to suggest 42:42:42:42:42:42 :-) Andrew