From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756420AbdJPQrl (ORCPT ); Mon, 16 Oct 2017 12:47:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46750 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbdJPQrk (ORCPT ); Mon, 16 Oct 2017 12:47:40 -0400 Date: Mon, 16 Oct 2017 18:47:37 +0200 From: Andrew Lunn To: Rodney Cummings Cc: Vivien Didelot , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@savoirfairelinux.com" , "David S. Miller" , Florian Fainelli , David Laight Subject: Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr Message-ID: <20171016164737.GD13339@lunn.ch> References: <20171013181809.14627-1-vivien.didelot@savoirfairelinux.com> <20171016160941.GA13339@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 04:28:04PM +0000, Rodney Cummings wrote: > Hi Andrew, > > I may have misunderstood. > > If this MAC address is the destination Nope. This is the source address, for Pause frames. > My concern is that for a source MAC address, a local random MAC > address is not safe in all networks, because it has the potential > for duplication. That topic has been discussed quite a bit in IEEE > 802. Duplications don't matter, for pause frames. The source address appears to be unused. And these frames don't get passed the direct peers MAC layer. Andrew