From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbdJPRLN (ORCPT ); Mon, 16 Oct 2017 13:11:13 -0400 Received: from mga01.intel.com ([192.55.52.88]:1848 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbdJPRLK (ORCPT ); Mon, 16 Oct 2017 13:11:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,387,1503385200"; d="scan'208";a="138996880" Date: Mon, 16 Oct 2017 22:45:23 +0530 From: Vinod Koul To: =?iso-8859-1?B?QnL8bnMs?= Stefan Cc: "linux-sunxi@googlegroups.com" , "devicetree@vger.kernel.org" , Chen-Yu Tsai , Andre Przywara , "linux-kernel@vger.kernel.org" , Dan Williams , Rob Herring , "dmaengine@vger.kernel.org" , Code Kipper , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree Message-ID: <20171016171523.GR30097@localhost> References: <20170928014928.2272-1-stefan.bruens@rwth-aachen.de> <6277478a-601a-48b0-8e1f-1d309049d4f4@rwthex-w2-a.rwth-ad.de> <20171016070217.GO30097@localhost> <1918888.BSE68NRsHe@sbruens-linux> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1918888.BSE68NRsHe@sbruens-linux> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 02:21:02PM +0000, Brüns, Stefan wrote: > On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote: > > On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Brüns wrote: > > > To avoid introduction of a new compatible for each small SoC/DMA > > > controller > > > variation, move the definition of the channel count to the devicetree. > > > > > > The number of vchans is no longer explicit, but limited by the highest > > > port/DMA request number. The result is a slight overallocation for SoCs > > > with a sparse port mapping. > > > > This doesnt apply for me, please check > > The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/ > vkoul/slave-dma.git/commit/?h=topic/ > sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc > , which removed the "const struct of_device_id *device;" declaration. > > > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > > index 7fce976a13d8..b5906da2a975 100644 > > --- a/drivers/dma/sun6i-dma.c > > +++ b/drivers/dma/sun6i-dma.c > > @@ -42,6 +42,9 @@ > .. > > @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match); > > static int sun6i_dma_probe(struct platform_device *pdev) > > { > > const struct of_device_id *device; > > + struct device_node *np = pdev->dev.of_node; > > struct sun6i_dma_dev *sdc; > > struct resource *res; > > int ret, i; > > Can you fix this up, or should I send a new version of this patch? rebased one please -- ~Vinod