From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755867AbdJPU0Y (ORCPT ); Mon, 16 Oct 2017 16:26:24 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53460 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753184AbdJPU0W (ORCPT ); Mon, 16 Oct 2017 16:26:22 -0400 Date: Mon, 16 Oct 2017 13:26:19 -0700 From: "Paul E. McKenney" To: Randy Dunlap Cc: LKML , "linux-doc@vger.kernel.org" , Jonathan Corbet Subject: Re: rcu kernel-doc issues (4.14-rc1) Reply-To: paulmck@linux.vnet.ibm.com References: <20170917044145.GZ3521@linux.vnet.ibm.com> <20170917174716.GA3611@linux.vnet.ibm.com> <20170917194910.GC3521@linux.vnet.ibm.com> <20171016200749.GF3521@linux.vnet.ibm.com> <0ac2ae0e-6e50-e708-9218-6febae9a58c9@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ac2ae0e-6e50-e708-9218-6febae9a58c9@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17101620-0040-0000-0000-000003B3A454 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007900; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000236; SDB=6.00932091; UDB=6.00469350; IPR=6.00712381; BA=6.00005641; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017564; XFM=3.00000015; UTC=2017-10-16 20:26:19 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101620-0041-0000-0000-000007A8AA12 Message-Id: <20171016202619.GG3521@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-16_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710160285 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 01:18:14PM -0700, Randy Dunlap wrote: > On 10/16/17 13:07, Paul E. McKenney wrote: > > On Mon, Oct 16, 2017 at 12:58:28PM -0700, Randy Dunlap wrote: > >> Hi Jonathan and Paul, > >> > >> Please include these fixes before 4.14 final. > > > > Hello, Randy, > > > > I currently have them queued up for the 4.15 merge window. Will that > > work for you? > > They should be fixed in 4.14 final IMO. OK, how about if I submit them to the 4.15 merge window, but add the appropriate -stable tags to get them backported? Yes, these are bugs, but I cannot in good conscience claim that they are v4.14 regressions. But if Jon agrees with you, I will of course create a patch series, pull request, or whatever and send it along to him. Thanx, Paul > >> Thanks. > >> > >> On 09/17/17 12:49, Paul E. McKenney wrote: > >>> On Sun, Sep 17, 2017 at 10:57:42AM -0700, Randy Dunlap wrote: > >>>> On 09/17/17 10:47, Paul E. McKenney wrote: > >>>>> On Sat, Sep 16, 2017 at 09:41:45PM -0700, Paul E. McKenney wrote: > >>>>>> On Sat, Sep 16, 2017 at 06:26:04PM -0700, Randy Dunlap wrote: > >>>>>>> On 4.14-rc1, I am seeing lots of warnings on rcu kernel-doc: > >>>>>>> > >>>>>>> .. kernel-doc:: include/linux/rcupdate.h > >>>>>>> :external: > >>>>>>> ./Documentation/core-api/kernel-api.rst:357: ERROR: Error in "kernel-doc" directive: > >>>>>>> unknown option: "external". > >>>>>> > >>>>>> $ grep external include/linux/rcupdate.h > >>>>>> * by a single external-to-structure RCU-protected pointer, then you may > >>>>>> * external-to-structure pointer -after- you have completely initialized > >>>>>> > >>>>>> Do these comments somehow qualify as an "external" option? If so, how > >>>>>> do I tell kernel-doc to ignore them? Or must I reword them to avoid > >>>>>> the word "external"? > >>>>>> > >>>>>>> .. kernel-doc:: include/linux/rcupdate_wait.h > >>>>>>> :external: > >>>>>>> ./Documentation/core-api/kernel-api.rst:360: ERROR: Error in "kernel-doc" directive: > >>>>>>> unknown option: "external". > >>>>>> > >>>>>> $ grep external include/linux/rcupdate_wait.h > >>>>>> > >>>>>> There is no occurrence of the string "external" in this file. So this > >>>>>> "external" option is unknown to me as well. So, any hints on how I > >>>>>> should interpret these error messages? > >>>>> > >>>>> And thanks to Akira Yokosawa for pointing out my confusion in reading > >>>>> these error messages. The line numbers of course apply to the file > >>>>> Documentation/core-api/kernel-api.rst rather than the various RCU > >>>>> C-language source files. > >>>>> > >>>>> The patch below removes the error messages for me. Is this what you > >>>>> had in mind? (Might need other options at some point, but somewhere > >>>>> to start.) > >>>>> > >>>> > >>>> Yes, much better. Thanks. > >>>> > >>>> Just some missing kernel-doc on parameters mostly remaining: > >>> > >>> I have now fixed a number of these, thank you. > >>> > >>> Any hints for how to represent code samples within a "/**" comment? > >>> > >>> /home/git/linux-2.6-tip/include/linux/rcupdate.h:559: ERROR: Unexpected indentation. > >>> /home/git/linux-2.6-tip/include/linux/rcupdate.h:563: WARNING: Block quote ends without a blank line; unexpected unindent. > >>> /home/git/linux-2.6-tip/include/linux/rcupdate.h:777: ERROR: Unexpected indentation. > >>> /home/git/linux-2.6-tip/include/linux/rcupdate.h:778: WARNING: Block quote ends without a blank line; unexpected unindent. > >>> > >>> Thanx, Paul > >>> > >>>> ../include/linux/rcupdate.h:818: warning: No description found for parameter 'p' > >>>> ../include/linux/rcupdate.h:818: warning: No description found for parameter 'v' > >>>> ../include/linux/rcupdate.h:826: warning: No description found for parameter 'p' > >>>> ../include/linux/rcupdate.h:826: warning: No description found for parameter 'v' > >>>> ../include/linux/srcu.h:95: warning: No description found for parameter 'sp' > >>>> ../kernel/rcu/srcutree.c:873: warning: No description found for parameter 'rhp' > >>>> ../kernel/rcu/srcutree.c:873: warning: Excess function parameter 'head' description in 'call_srcu' > >>>> ../include/linux/rculist.h:302: warning: Incorrect use of kernel-doc format: * list_first_or_null_rcu - get the first element from a list > >>>> ../include/linux/rculist.h:317: warning: No description found for parameter 'ptr' > >>>> ../include/linux/rculist.h:317: warning: No description found for parameter 'type' > >>>> ../include/linux/rculist.h:317: warning: No description found for parameter 'member' > >>>> ../kernel/rcu/sync.c:94: warning: No description found for parameter 'rsp' > >>>> ../kernel/rcu/sync.c:162: warning: No description found for parameter 'rcu' > >>>> ../kernel/rcu/sync.c:162: warning: Excess function parameter 'rsp' description in 'rcu_sync_func' > >>>> > >>>>> > >>>>> ------------------------------------------------------------------------ > >>>>> > >>>>> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst > >>>>> index 8282099e0cbf..30b2666bf494 100644 > >>>>> --- a/Documentation/core-api/kernel-api.rst > >>>>> +++ b/Documentation/core-api/kernel-api.rst > >>>>> @@ -352,44 +352,44 @@ Read-Copy Update (RCU) > >>>>> ---------------------- > >>>>> > >>>>> .. kernel-doc:: include/linux/rcupdate.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/rcupdate_wait.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/rcutree.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: kernel/rcu/tree.c > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: kernel/rcu/tree_plugin.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: kernel/rcu/tree_exp.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: kernel/rcu/update.c > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/srcu.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: kernel/rcu/srcutree.c > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/rculist_bl.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/rculist.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/rculist_nulls.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: include/linux/rcu_sync.h > >>>>> - :external: > >>>>> + :export > >>>>> > >>>>> .. kernel-doc:: kernel/rcu/sync.c > >>>>> - :external: > >>>>> + :export > >> > >> > >> -- > >> ~Randy > >> > > > > > -- > ~Randy >