From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbdJPV4x (ORCPT ); Mon, 16 Oct 2017 17:56:53 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47121 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbdJPV4v (ORCPT ); Mon, 16 Oct 2017 17:56:51 -0400 Date: Mon, 16 Oct 2017 14:56:47 -0700 From: Darren Hart To: Mario.Limonciello@dell.com Cc: pali.rohar@gmail.com, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org, quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, greg@kroah.com, gnomes@lxorguk.ukuu.org.uk Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI Message-ID: <20171016215647.GD14419@fury> References: <20171016073307.ahdc6ogzytzwckpq@pali> <0aebeec94bad4ca9baae335ef9e591b8@ausx13mpc120.AMER.DELL.COM> <20171016133705.cf4f5jqgq4ebhfcj@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 01:48:05PM +0000, Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > Sent: Monday, October 16, 2017 8:37 AM > > To: Limonciello, Mario > > Cc: dvhart@infradead.org; andy.shevchenko@gmail.com; linux- > > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; luto@kernel.org; > > quasisec@google.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de; > > greg@kroah.com; gnomes@lxorguk.ukuu.org.uk > > Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI > > > > On Monday 16 October 2017 13:23:04 Mario.Limonciello@dell.com wrote: > > > > -----Original Message----- > > > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > > > Sent: Monday, October 16, 2017 2:33 AM > > > > To: Limonciello, Mario > > > > Cc: dvhart@infradead.org; Andy Shevchenko ; > > > > LKML ; platform-driver-x86@vger.kernel.org; > > Andy > > > > Lutomirski ; quasisec@google.com; rjw@rjwysocki.net; > > > > mjg59@google.com; hch@lst.de; Greg KH ; Alan Cox > > > > > > > > Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI > > > > > > > > Hi! Just a small idea, what about including example userspace > > > > application which would use this new API? I think such application can > > > > be useful for documentation purpose to see how this new API should be > > > > used. And in review process other people can point if there would be > > > > some problems with usage. > > > > > > > > I do not know if it is requirement or not for introducing new kernel > > > > API, but still example code is very useful for developers when they > > > > would start to use this new API and correctly. > > > > > > > > -- > > > > Pali Rohár > > > > pali.rohar@gmail.com > > > > > > Pali, > > > > > > I've produced a small sample application available here: > > > https://github.com/superm1/smbios-wmi-poc > > > > Simple one-file example application. Great! > > > > Darren, Greg, Mario, I think it would be better to have this example > > application in tools/ or in Documentation/... What do you think? > > > > Looking for examples on random github repos is harder and less official > > as part of linux source tree. > > > > If others also agree, I'm fine with including it with the kernel. > Please advise where it should be located. > > It was originally a POC made just for my own testing of this API. > I will probably need to clean it up a little though for wider distribution > to the kernel so I would prefer to send it in a follow up patch if no other > feedback requiring changes to this series as is. > > One possible issue is that it currently uses glib. Is that OK? In my opinion, what is important is that there is an open-source userspace consumer of the interface. I don't think it needs to be in the kernel. If this was a more generic interface which could be tested on any hardware, then I think a selftests target would be sensible. As it is, this is a very specific use case, and a simple reference to the smbios-wmi-poc project URL in documentation someplace (or even in the dell-smbios driver comments) seems more than adequate to me. -- Darren Hart VMware Open Source Technology Center