From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760738AbdJQKPP (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 06:15:15 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:48551 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753138AbdJQKPM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 06:15:12 -0400
X-Google-Smtp-Source: AOwi7QBAhdd0AR3y5OHqGbMg2GXcybeHSbEtx/+faDbaU9Usp723mNtgbMcC1ekCg7kNWihVJVnhYg==
Date: Tue, 17 Oct 2017 19:15:07 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zram: make function zram_page_end_io static
Message-ID: <20171017101507.GE6915@jagdpanzerIV>
References: <20171016173336.20320-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171016173336.20320-1-colin.king@canonical.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

(Ccing Andrew, message id: 20171016173336.20320-1-colin.king@canonical.com )

On (10/16/17 18:33), Colin King wrote:
> The function zram_page_end_io is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'zram_page_end_io' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 88564222f473..d70eba30003a 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -428,7 +428,7 @@ static void put_entry_bdev(struct zram *zram, unsigned long entry)
>  	WARN_ON_ONCE(!was_set);
>  }
>  
> -void zram_page_end_io(struct bio *bio)
> +static void zram_page_end_io(struct bio *bio)
>  {
>  	struct page *page = bio->bi_io_vec[0].bv_page;
>  
> -- 
> 2.14.1
>