From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761234AbdJQKkt (ORCPT ); Tue, 17 Oct 2017 06:40:49 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:57105 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdJQKkr (ORCPT ); Tue, 17 Oct 2017 06:40:47 -0400 X-Google-Smtp-Source: ABhQp+TzjpoICPyW6LLr75Yd+rY3EhlGJt2pfxX4KL2zTAhufIpRtGiywYw3nPiKxz/Ud8iuTKzSGQ== Date: Tue, 17 Oct 2017 12:40:43 +0200 From: Thierry Reding To: Philipp Zabel Cc: Timo Alho , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] reset: tegra: check BPMP response return code Message-ID: <20171017104043.GB30589@ulmo> References: <00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline In-Reply-To: <00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cmJC7u66zC7hs+87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 07, 2017 at 12:31:03PM +0300, Timo Alho wrote: > Add checks for return code in BPMP response message. >=20 > Signed-off-by: Timo Alho > --- > drivers/reset/tegra/reset-bpmp.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) Hi Philipp, Would you provide an Acked-by on this so that I can take it into the Tegra tree? There's a build dependency on patch 1/4 in the series. Quoting in full since you were not previously on Cc, unfortunately. Timo, please remember to always Cc the relevant maintainers. Thierry > diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset= -bpmp.c > index 5daf2ee..fac2db6 100644 > --- a/drivers/reset/tegra/reset-bpmp.c > +++ b/drivers/reset/tegra/reset-bpmp.c > @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_control= ler_dev *rstc, > struct tegra_bpmp *bpmp =3D to_tegra_bpmp(rstc); > struct mrq_reset_request request; > struct tegra_bpmp_message msg; > + int err; > =20 > memset(&request, 0, sizeof(request)); > request.cmd =3D command; > @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_contro= ller_dev *rstc, > msg.tx.data =3D &request; > msg.tx.size =3D sizeof(request); > =20 > - return tegra_bpmp_transfer(bpmp, &msg); > + err =3D tegra_bpmp_transfer(bpmp, &msg); > + if (err < 0) > + return err; > + else if (msg.rx.ret < 0) > + return -EINVAL; > + > + return 0; > } > =20 > static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc, > --=20 > 2.7.4 >=20 --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlnl3isACgkQ3SOs138+ s6F/Sg/+IQ70ShJxvti68Bt1vuFgXEIhO/LtBw55Bp+c8Q1mG1DtTplH9U+sBsqc Djp3czOmJwgsYfglgfBdBC3WeDg+FZUl7NVvwXw8mYVtaXXemT07wXBcrEahvSiE L6SOElUVakmmV/DbmAO9PFVOL6zgO4QLmFU+9czuoTgF4eTnV9kPCZLAlanCaS+/ Yh22lKYa8K/M8bC1AH8N2Zs62ZWMLroiGZg1M/PvZW4lT+sqgQhi3D5TROAD7uv7 WZ4bqrssiVRGzTiZ0UiHX873tFgaFupvRQ7Q4s7uoOVClKcPCBLyvBoxuhNi18OZ fWkgDh4GLKa3qmkBI0Ev6Uk7pwtI/HhbGGDQsXLw332Vmj8GlmWi/z7ZJg0KCDDX X48hjeVzEsdVEcMWw1Yv9abDSmfG5IvRk8ioxlbMbtw7uzovRiRL0UCF6+4riOi7 3WNct+j45pCieUfimixlcJnrEGq/ompH3yBS7v6Ak8S+QflP/c++XC0dPRZycuyR gU92oUvJyTNM2LlN+ybX+H+oN6leG3Uvp2mn7UaKqJ0afxWDWr519lH17qp6aGIo cR7GXKNz5Rc1tmXvGl8z2JCOwxw/4IG/EC3tIHIi9mSE0BtRZq+KAQFl+rUsKchf vlF5ti7PItVQVp0nCXkB3AFO3QjAgYIYVwu19whc/rVZFR8IJwU= =dT2Y -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87--