From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759712AbdJQI7U (ORCPT ); Tue, 17 Oct 2017 04:59:20 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56470 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758210AbdJQI7S (ORCPT ); Tue, 17 Oct 2017 04:59:18 -0400 Date: Tue, 17 Oct 2017 10:59:10 +0200 From: Martin Schwidefsky To: Kees Cook Cc: Heiko Carstens , Peter Oberparleiter , Greg Kroah-Hartman , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390/sclp: Convert timers to use timer_setup() In-Reply-To: <20171016234430.GA102114@beast> References: <20171016234430.GA102114@beast> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17101708-0008-0000-0000-000004A09033 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101708-0009-0000-0000-00001E32D719 Message-Id: <20171017105910.5735a5b9@mschwideX1> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-17_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710170126 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Oct 2017 16:44:30 -0700 Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Instead of creating an external static > data variable, just define a separate callback which encodes the "force > restart" desire. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Peter Oberparleiter > Cc: Greg Kroah-Hartman > Cc: linux-s390@vger.kernel.org > Signed-off-by: Kees Cook > --- > drivers/s390/char/con3215.c | 6 +++--- > drivers/s390/char/con3270.c | 10 +++++----- > drivers/s390/char/sclp.c | 45 ++++++++++++++++++++++++------------------ > drivers/s390/char/sclp_con.c | 5 ++--- > drivers/s390/char/sclp_tty.c | 5 ++--- > drivers/s390/char/sclp_vt220.c | 6 ++---- > drivers/s390/char/tape_core.c | 14 ++++--------- > drivers/s390/char/tty3270.c | 8 ++++---- > 8 files changed, 48 insertions(+), 51 deletions(-) Applied to s390/linux:feature branch. Thanks. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.