From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757731AbdJQM7X (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 08:59:23 -0400
Received: from foss.arm.com ([217.140.101.70]:46012 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754611AbdJQM7W (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 08:59:22 -0400
Date: Tue, 17 Oct 2017 13:59:26 +0100
From: Will Deacon <will.deacon@arm.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, linuxarm@huawei.com,
        jonathan.cameron@huawei.com, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
        John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] perf vendor events arm64: Add hip08 implementation
 defined PMU core events
Message-ID: <20171017125926.GE14051@arm.com>
References: <1508223699-39274-1-git-send-email-zhangshaokun@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1508223699-39274-1-git-send-email-zhangshaokun@hisilicon.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaokun,

Thanks for the patch. One comment below.

On Tue, Oct 17, 2017 at 03:01:39PM +0800, Shaokun Zhang wrote:
> This is a short list of useful implementation defined PMU events of
> hip08, other supported events are not listed in this JSON file.
> 
> This patch is dependent on Cavium's patch-v9 (Add support for
> ThunderX2 pmu events using json files), Link:
> https://www.spinics.net/lists/arm-kernel/msg611895.html
> 
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> Cc: John Garry <john.garry@huawei.com>
> ---
>  .../arch/arm64/hisilicon/hip08-imp-def.json        | 176 +++++++++++++++++++++
>  tools/perf/pmu-events/arch/arm64/mapfile.csv       |   1 +
>  2 files changed, 177 insertions(+)
>  create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08-imp-def.json
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08-imp-def.json b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08-imp-def.json
> new file mode 100644
> index 0000000..6bb31da
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08-imp-def.json
> @@ -0,0 +1,176 @@
> +[
> +    {
> +        "PublicDescription": "Attributable Level 1 data cache access, read",
> +        "EventCode": "0x40",
> +        "EventName": "L1D_CACHE_RD",
> +        "BriefDescription": "L1D cache access, read",
> +    },
> +    {
> +        "PublicDescription": "Attributable Level 1 data cache access, write",
> +        "EventCode": "0x41",
> +        "EventName": "L1D_CACHE_WR",
> +        "BriefDescription": "L1D cache access, write",
> +    },

So these are the same as the events in cavium/thunderx2-imp-def.json and
should be factored out. In fact, ARM recommends event numbers for 0x40-0xBF,
so the best thing would be to have those defined in their own file, then
have a way for the various CPU-specific .json files to pick and chose the
events they need from there.

Will