Re: [PATCH] perf vendor events arm64: Add hip08 implementation defined PMU core events

John Garry
2017-10-25T11:08:10Z

On 25/10/2017 11:06, Ganapatrao Kulkarni wrote:
> Hi John,
>
> On Thu, Oct 19, 2017 at 3:59 PM, John Garry <john.garry@huawei.com> wrote:
>>>>
>>>> #Family-model,Version,Filename,EventType
>>>> 0x00000000420f5160,v1,cavium,core
>>>> 0x00000000420f5161,v1,cavium,core
>>>
>>>
>>> certainly, there is Part number(PartNum, bits [15:4] ) change from
>>> thunderx2 to thunderx3.
>>> thunderx3 should have its own json file describing all its supported
>>> events.
>>> same applies to other SoCs as well.
>>>
>>> IIUC, the idea of ignoring Revision and Variants is that, the PMU
>>> design/version wont change across Revisions and Variants.
>>>
>>
>> Hi Ganapatrao,
>>
>> Right, I should have modified the part num for my illustration, but I am
>> still concerned. Please see my example in the other mail and check what I am
>> missing.
>

Hi Ganapatrao,

> ok, then my original naming was more appropriate.

It was better.

For now, until we introduce > 1 json per vendor, we're fine with the
structure as-is.

> i.e have josn files defined in SoC directory, instead of having single
> vendor directory for all SoC json files.
>
> like,
> pmu-events/arch/arm64/thunderx2
> pmu-events/arch/arm64/thunderx3
> pmu-events/arch/arm64/hip08
> pmu-events/arch/arm64/hip09

We're now looking (slowly) at the task of factoring out the common,
ARM-recommended events, and this directory structure issue is not a
blocker, but clarification would be nice.

Cheers,
John