From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761411AbdJQXXX (ORCPT ); Tue, 17 Oct 2017 19:23:23 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:49714 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754973AbdJQXXU (ORCPT ); Tue, 17 Oct 2017 19:23:20 -0400 X-Google-Smtp-Source: ABhQp+TFaPuYdQRJ66DpUUBPtk0KQniFGJToTWM0cGkr+VMtKG8Z3FqjqPsEc+x2810RjjJBYEc/4Q== Date: Tue, 17 Oct 2017 16:23:16 -0700 From: Eric Biggers To: David Howells Cc: jmorris@namei.org, torvalds@linux-foundation.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Tyler Hicks Subject: Re: [GIT PULL] KEYS: Fixes Message-ID: <20171017232316.GA29388@google.com> References: <866.1508281053@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <866.1508281053@warthog.procyon.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc tyhicks@canonical.com Hi David, On Tue, Oct 17, 2017 at 11:57:33PM +0100, David Howells wrote: > > (2) Fix some ecryptfs bits. Sorry for the late notice, but just looking at it again I think the patch "ecryptfs: fix out-of-bounds read of key payload" is broken because the ->private_key is of variable-length. See ecryptfs_add_key_module_key_to_keyring() in ecryptfs-utils. So can you please drop the following two patches: ecryptfs: fix out-of-bounds read of key payload ecryptfs: move key payload accessor functions into keystore.c I'll fix them and try to get Tyler Hicks to take them through the ecryptfs tree later instead. Eric