From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755689AbdJRCgN (ORCPT ); Tue, 17 Oct 2017 22:36:13 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:32893 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755186AbdJRCgL (ORCPT ); Tue, 17 Oct 2017 22:36:11 -0400 X-ME-Sender: Date: Wed, 18 Oct 2017 13:36:07 +1100 From: "Tobin C. Harding" To: sunil.m@techveda.org Cc: gilad@benyossef.com, gregkh@linuxfoundation.org, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, karthik@techveda.org Subject: Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning Message-ID: <20171018023607.GE30848@eros> References: <20171016211906.GN16106@eros> <1508292773-15853-1-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508292773-15853-1-git-send-email-sunil.m@techveda.org> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 07:42:53AM +0530, sunil.m@techveda.org wrote: > From: Suniel Mahesh > > Return "false" instead of 0. > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. So close! The order of problem description and fix is inverted. What about ``` coccinelle emits: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Return "false" instead of 0. ``` Good luck, Tobin.