The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: johan@kernel.org, arnd@arndb.de, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	peterz@infradead.org, hpa@zytor.com, tony@atomide.com,
	linux-tip-commits@vger.kernel.org, kernel-team@lge.com
Subject: Re: [tip:locking/urgent] locking/lockdep: Disable cross-release features for now
Date: Wed, 18 Oct 2017 14:31:24 +0900	[thread overview]
Message-ID: <20171018053124.GB32368@X58A-UD3R> (raw)
In-Reply-To: <20171017071202.6x22ho2o5yz74dak@gmail.com>

On Tue, Oct 17, 2017 at 09:12:02AM +0200, Ingo Molnar wrote:
> > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > > index 2689b7c..e270584 100644
> > > --- a/lib/Kconfig.debug
> > > +++ b/lib/Kconfig.debug
> > > @@ -1092,8 +1092,8 @@ config PROVE_LOCKING
> > >  	select DEBUG_MUTEXES
> > >  	select DEBUG_RT_MUTEXES if RT_MUTEXES
> > >  	select DEBUG_LOCK_ALLOC
> > > -	select LOCKDEP_CROSSRELEASE
> > > -	select LOCKDEP_COMPLETIONS
> > > +	select LOCKDEP_CROSSRELEASE if BROKEN
> > > +	select LOCKDEP_COMPLETIONS if BROKEN
> > 
> > I agree with disabling crossrelease as default, becasue of regression,
> > as I originally did.
> > 
> > However, it's expected to spend more time once it's enabled. Is the
> > following acceptable?
> 
> No, please fix performance.

OK. I will fx the performance problem by making the unwinding optional.

      parent reply	other threads:[~2017-10-18  5:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13  9:03 Dramatic lockdep slowdown in 4.14 Johan Hovold
2017-10-13  9:07 ` Peter Zijlstra
2017-10-13  9:35   ` Johan Hovold
2017-10-14  7:26 ` Ingo Molnar
2017-10-14  8:11   ` Johan Hovold
2017-10-14 11:36   ` [tip:locking/urgent] locking/lockdep: Disable cross-release features for now tip-bot for Ingo Molnar
2017-10-16  2:04     ` Byungchul Park
2017-10-17  7:12       ` Ingo Molnar
2017-10-17  7:40         ` Thomas Gleixner
2017-10-17 14:42           ` Ingo Molnar
2017-10-17 15:03             ` Thomas Gleixner
2017-10-17 16:21               ` Ingo Molnar
2017-10-18  7:48               ` Byungchul Park
2017-10-18  5:31         ` Byungchul Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171018053124.GB32368@X58A-UD3R \
    --to=byungchul.park@lge.com \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=johan@kernel.org \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox