From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758406AbdJRGTq (ORCPT ); Wed, 18 Oct 2017 02:19:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52634 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756948AbdJRGTp (ORCPT ); Wed, 18 Oct 2017 02:19:45 -0400 Date: Wed, 18 Oct 2017 08:19:52 +0200 From: Greg Kroah-Hartman To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net, dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org, seanpaul@chromium.org, thierry.reding@gmail.com Subject: Re: [PATCH] driver core: Make sure device detached from driver before deleting it Message-ID: <20171018061952.GA18857@kroah.com> References: <20171018054926.4756-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171018054926.4756-1-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 01:49:26PM +0800, Jeffy Chen wrote: > There are cases we call device_del() without detaching it from the > driver(e.g. spi core del children devices). Why would you do that? Shouldn't that be fixed instead of this odd work-around for a broken bus? thanks, greg k-h