From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762765AbdJRINY (ORCPT ); Wed, 18 Oct 2017 04:13:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39978 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762716AbdJRIMy (ORCPT ); Wed, 18 Oct 2017 04:12:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E23175F739 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 18 Oct 2017 10:12:51 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH] perf util: Fix wrong processing when closing evsel fd Message-ID: <20171018081251.GA16747@krava> References: <1508339478-26674-1-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508339478-26674-1-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 18 Oct 2017 08:12:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 11:11:18PM +0800, Jin Yao wrote: SNIP > This change is introduced by "475fb533fb7d" > ("perf evsel: Fix buffer overflow while freeing events") > > This fix is to let xyarray__max_x() return max_x (ncpus) and > let xyarry__max_y() return max_y (nthreads) > > Signed-off-by: Jin Yao > --- > tools/perf/util/xyarray.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/xyarray.h b/tools/perf/util/xyarray.h > index 4ba726c..54af6046 100644 > --- a/tools/perf/util/xyarray.h > +++ b/tools/perf/util/xyarray.h > @@ -23,12 +23,12 @@ static inline void *xyarray__entry(struct xyarray *xy, int x, int y) > > static inline int xyarray__max_y(struct xyarray *xy) > { > - return xy->max_x; > + return xy->max_y; > } > > static inline int xyarray__max_x(struct xyarray *xy) > { > - return xy->max_y; > + return xy->max_x; > } oops, thanks! Acked-by: Jiri Olsa jirka