public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: rui_feng@realsil.com.cn
Cc: lee.jones@linaro.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org, ricky_wu@realtek.com
Subject: Re: [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc
Date: Wed, 18 Oct 2017 11:16:41 +0200	[thread overview]
Message-ID: <20171018091641.GA14187@kroah.com> (raw)
In-Reply-To: <1508316305-18385-1-git-send-email-rui_feng@realsil.com.cn>

On Wed, Oct 18, 2017 at 04:45:05PM +0800, rui_feng@realsil.com.cn wrote:
> From: rui_feng <rui_feng@realsil.com.cn>

I doubt you sign your documents "rui_feng", shouldn't it be "Rui Feng"?

Same for your signed-off-by line.

> 
> Move Realtek PCIE Card Reader Driver to misc.
> 1.Create a folder realtek to store rtl8411.c rts5209.c
> rts5227.c rts5229.c rts5249.c rtsx_pcr.c rtsx_pcr.h.

That's not a changelog description, please read other driver changelogs
for examples of what you need here (what the driver is, why it is
needed, what it does, etc.)

thanks,

greg k-h

      parent reply	other threads:[~2017-10-18  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18  8:45 [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc rui_feng
2017-10-18  8:56 ` Arnd Bergmann
2017-10-18  9:21   ` 答复: " 冯锐
2017-10-18  9:38     ` gregkh
2017-10-18  9:42     ` Arnd Bergmann
2017-10-18  9:16 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171018091641.GA14187@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricky_wu@realtek.com \
    --cc=rui_feng@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox