From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936643AbdJRJQg (ORCPT ); Wed, 18 Oct 2017 05:16:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35228 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936573AbdJRJQd (ORCPT ); Wed, 18 Oct 2017 05:16:33 -0400 Date: Wed, 18 Oct 2017 11:16:41 +0200 From: Greg KH To: rui_feng@realsil.com.cn Cc: lee.jones@linaro.org, arnd@arndb.de, linux-kernel@vger.kernel.org, ricky_wu@realtek.com Subject: Re: [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc Message-ID: <20171018091641.GA14187@kroah.com> References: <1508316305-18385-1-git-send-email-rui_feng@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508316305-18385-1-git-send-email-rui_feng@realsil.com.cn> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 04:45:05PM +0800, rui_feng@realsil.com.cn wrote: > From: rui_feng I doubt you sign your documents "rui_feng", shouldn't it be "Rui Feng"? Same for your signed-off-by line. > > Move Realtek PCIE Card Reader Driver to misc. > 1.Create a folder realtek to store rtl8411.c rts5209.c > rts5227.c rts5229.c rts5249.c rtsx_pcr.c rtsx_pcr.h. That's not a changelog description, please read other driver changelogs for examples of what you need here (what the driver is, why it is needed, what it does, etc.) thanks, greg k-h