From: gregkh <gregkh@linuxfoundation.org>
To: 冯锐 <rui_feng@realsil.com.cn>
Cc: Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"ricky_wu@realtek.com" <ricky_wu@realtek.com>
Subject: Re: 答复: [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc
Date: Wed, 18 Oct 2017 11:38:51 +0200 [thread overview]
Message-ID: <20171018093851.GA2589@kroah.com> (raw)
In-Reply-To: <2A308283684ECD4B896628E09AF5361E01A73C8E@RS-MBS01.realsil.com.cn>
On Wed, Oct 18, 2017 at 09:21:44AM +0000, 冯锐 wrote:
> > On Wed, Oct 18, 2017 at 10:45 AM, <rui_feng@realsil.com.cn> wrote:
> > > From: rui_feng <rui_feng@realsil.com.cn>
> > >
> > > Move Realtek PCIE Card Reader Driver to misc.
> > > 1.Create a folder realtek to store rtl8411.c rts5209.c rts5227.c
> > > rts5229.c rts5249.c rtsx_pcr.c rtsx_pcr.h.
> > > 2.Move include/linux/mfd/rtsx_common.h and
> > > include/linux/mfd/rtsx_pci.h to include/linux.
> > > 3.Move all Kconfig and Makefile related to Realtek card readers to misc.
> > >
> > > Signed-off-by: rui_feng <rui_feng@realsil.com.cn>
> > > ---
> > > drivers/memstick/host/rtsx_pci_ms.c | 2 +-
> > > drivers/mfd/Kconfig | 11 -
> > > drivers/mfd/Makefile | 2 -
> > > drivers/mfd/rtl8411.c | 508 ------------
> > > drivers/mfd/rts5209.c | 277 -------
> > > drivers/mfd/rts5227.c | 374 ---------
> >
> > Please update the patch with two changes:
> >
> > 1. rewrite the changelog completely to explain *why* you do this. We can see
> > from the patch what it does, no need to go into detail about it beyond the
> > subject, but I have no idea what this is good for.
> >
> Because Realtek PCIE card reader driver is a pcie driver, and it bridges mmc subsystem and memstick subsystem, it's not a mfd driver.
> Greg and Lee Jones had a discuss about where to put the driver, the result is that misc is a good place for it, so I move all files to misc.
> If I don't move it to a right place, I can't add any patch for new chip support.
Great, explain that in the changelog description!
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-18 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 8:45 [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc rui_feng
2017-10-18 8:56 ` Arnd Bergmann
2017-10-18 9:21 ` 答复: " 冯锐
2017-10-18 9:38 ` gregkh [this message]
2017-10-18 9:42 ` Arnd Bergmann
2017-10-18 9:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018093851.GA2589@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=rui_feng@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox