From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967268AbdJRJip (ORCPT ); Wed, 18 Oct 2017 05:38:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35816 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933248AbdJRJin (ORCPT ); Wed, 18 Oct 2017 05:38:43 -0400 Date: Wed, 18 Oct 2017 11:38:51 +0200 From: gregkh To: =?utf-8?B?5Yav6ZSQ?= Cc: Arnd Bergmann , Lee Jones , Linux Kernel Mailing List , "ricky_wu@realtek.com" Subject: Re: =?utf-8?B?562U5aSN?= =?utf-8?Q?=3A?= [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc Message-ID: <20171018093851.GA2589@kroah.com> References: <1508316305-18385-1-git-send-email-rui_feng@realsil.com.cn> <2A308283684ECD4B896628E09AF5361E01A73C8E@RS-MBS01.realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2A308283684ECD4B896628E09AF5361E01A73C8E@RS-MBS01.realsil.com.cn> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 09:21:44AM +0000, 冯锐 wrote: > > On Wed, Oct 18, 2017 at 10:45 AM, wrote: > > > From: rui_feng > > > > > > Move Realtek PCIE Card Reader Driver to misc. > > > 1.Create a folder realtek to store rtl8411.c rts5209.c rts5227.c > > > rts5229.c rts5249.c rtsx_pcr.c rtsx_pcr.h. > > > 2.Move include/linux/mfd/rtsx_common.h and > > > include/linux/mfd/rtsx_pci.h to include/linux. > > > 3.Move all Kconfig and Makefile related to Realtek card readers to misc. > > > > > > Signed-off-by: rui_feng > > > --- > > > drivers/memstick/host/rtsx_pci_ms.c | 2 +- > > > drivers/mfd/Kconfig | 11 - > > > drivers/mfd/Makefile | 2 - > > > drivers/mfd/rtl8411.c | 508 ------------ > > > drivers/mfd/rts5209.c | 277 ------- > > > drivers/mfd/rts5227.c | 374 --------- > > > > Please update the patch with two changes: > > > > 1. rewrite the changelog completely to explain *why* you do this. We can see > > from the patch what it does, no need to go into detail about it beyond the > > subject, but I have no idea what this is good for. > > > Because Realtek PCIE card reader driver is a pcie driver, and it bridges mmc subsystem and memstick subsystem, it's not a mfd driver. > Greg and Lee Jones had a discuss about where to put the driver, the result is that misc is a good place for it, so I move all files to misc. > If I don't move it to a right place, I can't add any patch for new chip support. Great, explain that in the changelog description! thanks, greg k-h