* [PATCH] staging: rtlwifi: remove duplicated macros in comments
@ 2017-10-05 23:44 Matthew Giassa
2017-10-18 13:47 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Giassa @ 2017-10-05 23:44 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, kvalo, davem, khoroshilov, georgiana.chelu93,
johannes.berg, devel, linux-kernel, matthew
Removing a comment that duplicates definitions for pci_power_t
enumeration, and pointing to the relevant header file (current comment
is also missing PCI_POWER_ERROR).
Signed-off-by: Matthew Giassa <matthew@giassa.net>
---
drivers/staging/rtlwifi/pci.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c
index 4035b88..2e2cd21 100644
--- a/drivers/staging/rtlwifi/pci.c
+++ b/drivers/staging/rtlwifi/pci.c
@@ -2456,12 +2456,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
#ifdef CONFIG_PM_SLEEP
/***************************************
* kernel pci power state define:
- * PCI_D0 ((pci_power_t __force) 0)
- * PCI_D1 ((pci_power_t __force) 1)
- * PCI_D2 ((pci_power_t __force) 2)
- * PCI_D3hot ((pci_power_t __force) 3)
- * PCI_D3cold ((pci_power_t __force) 4)
- * PCI_UNKNOWN ((pci_power_t __force) 5)
+ * Refer to include/linux/pci.h
* This function is called when system
* goes into suspend state mac80211 will
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments
2017-10-05 23:44 [PATCH] staging: rtlwifi: remove duplicated macros in comments Matthew Giassa
@ 2017-10-18 13:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-10-18 13:47 UTC (permalink / raw)
To: Matthew Giassa
Cc: devel, georgiana.chelu93, johannes.berg, linux-kernel, kvalo,
davem, khoroshilov, Larry.Finger
On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote:
> Removing a comment that duplicates definitions for pci_power_t
> enumeration, and pointing to the relevant header file (current comment
> is also missing PCI_POWER_ERROR).
>
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
> drivers/staging/rtlwifi/pci.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c
> index 4035b88..2e2cd21 100644
> --- a/drivers/staging/rtlwifi/pci.c
> +++ b/drivers/staging/rtlwifi/pci.c
> @@ -2456,12 +2456,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
> #ifdef CONFIG_PM_SLEEP
> /***************************************
> * kernel pci power state define:
> - * PCI_D0 ((pci_power_t __force) 0)
> - * PCI_D1 ((pci_power_t __force) 1)
> - * PCI_D2 ((pci_power_t __force) 2)
> - * PCI_D3hot ((pci_power_t __force) 3)
> - * PCI_D3cold ((pci_power_t __force) 4)
> - * PCI_UNKNOWN ((pci_power_t __force) 5)
> + * Refer to include/linux/pci.h
That's really vague, how about just deleting these lines, and the
previous one as well?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-18 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-05 23:44 [PATCH] staging: rtlwifi: remove duplicated macros in comments Matthew Giassa
2017-10-18 13:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox