From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbdJRNrL (ORCPT ); Wed, 18 Oct 2017 09:47:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60712 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbdJRNrK (ORCPT ); Wed, 18 Oct 2017 09:47:10 -0400 Date: Wed, 18 Oct 2017 15:47:18 +0200 From: Greg KH To: Matthew Giassa Cc: devel@driverdev.osuosl.org, georgiana.chelu93@gmail.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, kvalo@codeaurora.org, davem@davemloft.net, khoroshilov@ispras.ru, Larry.Finger@lwfinger.net Subject: Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments Message-ID: <20171018134718.GA32092@kroah.com> References: <1507247071-2224-1-git-send-email-matthew@giassa.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507247071-2224-1-git-send-email-matthew@giassa.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote: > Removing a comment that duplicates definitions for pci_power_t > enumeration, and pointing to the relevant header file (current comment > is also missing PCI_POWER_ERROR). > > Signed-off-by: Matthew Giassa > --- > drivers/staging/rtlwifi/pci.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c > index 4035b88..2e2cd21 100644 > --- a/drivers/staging/rtlwifi/pci.c > +++ b/drivers/staging/rtlwifi/pci.c > @@ -2456,12 +2456,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev) > #ifdef CONFIG_PM_SLEEP > /*************************************** > * kernel pci power state define: > - * PCI_D0 ((pci_power_t __force) 0) > - * PCI_D1 ((pci_power_t __force) 1) > - * PCI_D2 ((pci_power_t __force) 2) > - * PCI_D3hot ((pci_power_t __force) 3) > - * PCI_D3cold ((pci_power_t __force) 4) > - * PCI_UNKNOWN ((pci_power_t __force) 5) > + * Refer to include/linux/pci.h That's really vague, how about just deleting these lines, and the previous one as well? thanks, greg k-h