From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbdJRNxg (ORCPT ); Wed, 18 Oct 2017 09:53:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33054 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbdJRNxe (ORCPT ); Wed, 18 Oct 2017 09:53:34 -0400 Date: Wed, 18 Oct 2017 15:53:42 +0200 From: Greg KH To: Srishti Sharma Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtlwifi: phydm: Use setup_timer Message-ID: <20171018135342.GA16676@kroah.com> References: <1507397185-6139-1-git-send-email-srishtishar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507397185-6139-1-git-send-email-srishtishar@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 07, 2017 at 10:56:25PM +0530, Srishti Sharma wrote: > Use setup_timer to combine initialization of a timer with the > initialization of the timer's function and data fields. Done > using the following semantic patch by coccinelle. > > @r@ > struct timer_list *l; > expression f, d; > @@ > > -init_timer(l); > +setup_timer(l,f,d); > ... > > ( > - l->function = f; > ... > - l->data = d; > | > - l->data = d; > ... > - l->function = f; > ) > > Signed-off-by: Srishti Sharma > Acked-by: Julia Lawall > --- > drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Due to other changes in this same function, this patch no longer applies, sorry. greg k-h