From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdJSIPS (ORCPT ); Thu, 19 Oct 2017 04:15:18 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:47349 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbdJSIPO (ORCPT ); Thu, 19 Oct 2017 04:15:14 -0400 X-Google-Smtp-Source: ABhQp+R4uquQorgBtZLP1uJteFMtuNaguEmKNldST2m1Ad95verpZ9sckv07MhFj8FFF5MqAaqkpnw== Date: Thu, 19 Oct 2017 10:15:10 +0200 From: Thierry Reding To: Lukasz Majewski Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel Message-ID: <20171019081510.GA4459@ulmo> References: <1504863782-3293-1-git-send-email-lukma@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <1504863782-3293-1-git-send-email-lukma@denx.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 08, 2017 at 11:43:02AM +0200, Lukasz Majewski wrote: > This commit adds support for Mitsubishi aa070mc01 TFT panel working > with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). >=20 > Signed-off-by: Lukasz Majewski > --- > drivers/gpu/drm/panel/panel-simple.c | 35 ++++++++++++++++++++++++++++++= +++++ > 1 file changed, 35 insertions(+) This is missing a device tree binding. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index 3d2cb8b..0c64ec6 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = =3D { > }, > }; > =20 > +static const struct drm_display_mode mitsubishi_aa070mc01_mode =3D { > + .clock =3D 30400, > + .hdisplay =3D 800, > + .hsync_start =3D 800 + 0, > + .hsync_end =3D 800 + 1, > + .htotal =3D 800 + 0 + 1 + 160, > + .vdisplay =3D 480, > + .vsync_start =3D 480 + 0, > + .vsync_end =3D 480 + 48 + 1, > + .vtotal =3D 480 + 48 + 1 + 0, > + .vrefresh =3D 60, > + .flags =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > +}; > + > +static const struct panel_desc mitsubishi_aa070mc01 =3D { > + .modes =3D &mitsubishi_aa070mc01_mode, > + .num_modes =3D 1, > + .bpc =3D 8, > + .size =3D { > + .width =3D 152, > + .height =3D 91, > + }, > + > + .delay =3D { > + .enable =3D 200, > + .unprepare =3D 200, > + .disable =3D 400, > + }, > + .bus_format =3D MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > + .bus_flags =3D DRM_BUS_FLAG_DE_HIGH, > +}; And this isn't sorted properly. > + > static const struct drm_display_mode innolux_n116bge_mode =3D { > .clock =3D 76420, > .hdisplay =3D 1366, > @@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[= ] =3D { > .compatible =3D "innolux,g121x1-l03", > .data =3D &innolux_g121x1_l03, > }, { > + .compatible =3D "mitsubishi,aa070mc01-ca1", > + .data =3D &mitsubishi_aa070mc01, > + }, { Same here. Thierry --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlnoXwkACgkQ3SOs138+ s6Ghqw/+OE6lXcOFP8RKEw0cSrYu1C2VcjEpc4aNGqvhmt3JqyxYp0xOfUFVrvvz EnFF4DyzglDUy4BXGSUXYDrQ1/Cr1kqMQ5KwTCZlfZ4kBuccaYjmc/oA534BPLmv 6Dcx3E4mi+JNGKFcYkyJXJUPYpqUNhjgyOb6KCPbAjsuloJM293BT/Euuaevwx4M TUaWwI+taa/YW/oMlNW0PWPag/TfAzeqN5LeV2Qcl/w+72Q8xq/kWm9QYGjFdrKG jqbXZQYLdsFDppYh+nT6BebYiCQBzDFPFCANPA67I6panCUqhNvBoa+da500Prze BBfH41+s8jf7Xs73Tqv7BeqNxy9KyFf+bTKAxXqjvIRt/LjFv5FRQg9JJzR5vShP Itxq5XkamxHqc9kBIYYkuUA2jR3xJv/IekYV+jpiy4tdK2eoFIe+Zh4ymOFAWv+1 W88MW0Ib6XGZnUl1kPnq9BN4R0nUHIaLs1cQ0Zak2gE3RL44duDUlV5jqhNuRFUo gM7q6s6H48bmq/GD65iNbhzlsgpc7kzr/SE9ZtiZqL52xD0tFg0M+oQCCnlVlouU yf4mg7HC556h4eOAf7nGGZkOtXa4jymi8d7mvKUgJBz7LohOVh05njK7TGqyt71y elHSWVyx1N1iZFyLCYQmYfqsEtfoTtue2dL13OUVv7PzxMKWEk8= =0myq -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--