From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbdJSMhe (ORCPT ); Thu, 19 Oct 2017 08:37:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:36620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbdJSMhd (ORCPT ); Thu, 19 Oct 2017 08:37:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 513E9218A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 19 Oct 2017 09:37:30 -0300 From: Arnaldo Carvalho de Melo To: Christophe JAILLET Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] perf kmem: Perform some cleanup if '--time' is given an invalid value Message-ID: <20171019123730.GJ3707@kernel.org> References: <20170916060936.28199-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170916060936.28199-1-christophe.jaillet@wanadoo.fr> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Sep 16, 2017 at 08:09:36AM +0200, Christophe JAILLET escreveu: > If the string passed in '--time' is invalid, we must do some cleanup > before leaving. As in the other error handling paths of this function. Thanks, applied. - Arnaldo > Fixes: 2a865bd8dddd ("perf kmem: Add option to specify time window of interest") > Signed-off-by: Christophe JAILLET > --- > tools/perf/builtin-kmem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c > index 24ee68ecdd42..d8f25ef8157b 100644 > --- a/tools/perf/builtin-kmem.c > +++ b/tools/perf/builtin-kmem.c > @@ -1983,7 +1983,8 @@ int cmd_kmem(int argc, const char **argv) > > if (perf_time__parse_str(&ptime, time_str) != 0) { > pr_err("Invalid time string\n"); > - return -EINVAL; > + ret = -EINVAL; > + goto out_delete; > } > > if (!strcmp(argv[0], "stat")) { > -- > 2.11.0