From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: dvhart@infradead.org, Andy Shevchenko <andy.shevchenko@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Andy Lutomirski <luto@kernel.org>,
quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com,
hch@lst.de, Greg KH <greg@kroah.com>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v10 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver
Date: Thu, 19 Oct 2017 20:06:00 +0200 [thread overview]
Message-ID: <20171019180600.6gp7ch3z3bgbkqwt@pali> (raw)
In-Reply-To: <d68852a032398142e5277137f2a18ff6a5bee999.1508434513.git.mario.limonciello@dell.com>
On Thursday 19 October 2017 12:50:08 Mario Limonciello wrote:
> + priv->interface_version = buffer[2];
> + priv->size = buffer[3];
> + ret = 0;
> + dev_set_drvdata(&wdev->dev, priv);
> + list_add_tail(&priv->list, &wmi_list);
Still missing lock when changing wmi_list.
> +
> + dev_dbg(&wdev->dev, "Detected Dell WMI interface version %lu and buffer size %lu\n",
> + (unsigned long) priv->interface_version,
> + (unsigned long) priv->size);
> +
> +out:
> + kfree(obj);
> + return ret;
> +}
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-10-19 18:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 17:50 [PATCH v10 00/15] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 01/15] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 02/15] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 03/15] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-10-19 17:55 ` Pali Rohár
2017-10-19 17:50 ` [PATCH v10 04/15] platform/x86: dell-wmi: don't check length returned Mario Limonciello
2017-10-19 17:56 ` Pali Rohár
2017-10-19 17:50 ` [PATCH v10 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-10-19 18:06 ` Pali Rohár [this message]
2017-10-19 17:50 ` [PATCH v10 06/15] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 07/15] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 09/15] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 10/15] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 11/15] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-10-19 18:09 ` Pali Rohár
2017-10-19 18:12 ` Mario.Limonciello
2017-10-19 22:46 ` Darren Hart
2017-10-19 17:50 ` [PATCH v10 12/15] platform/x86: dell-smbios: Add filtering support Mario Limonciello
2018-01-05 11:13 ` Pali Rohár
2018-01-05 14:32 ` Mario.Limonciello
2018-01-05 14:44 ` Pali Rohár
2018-01-05 14:48 ` Mario.Limonciello
2018-01-27 14:51 ` Pali Rohár
2018-01-29 16:22 ` Mario.Limonciello
2018-01-29 16:44 ` Pali Rohár
2018-01-05 14:44 ` Andy Shevchenko
2017-10-19 17:50 ` [PATCH v10 13/15] platform/x86: wmi: create userspace interface for drivers Mario Limonciello
2017-10-20 13:21 ` Greg KH
2017-10-20 13:54 ` Mario.Limonciello
2017-10-20 14:48 ` Christoph Hellwig
2017-10-20 15:07 ` Mario.Limonciello
2017-10-20 15:08 ` Christoph Hellwig
2017-10-20 15:31 ` Mario.Limonciello
2017-10-20 14:57 ` Greg KH
2017-10-20 13:22 ` Greg KH
2017-10-20 13:54 ` Mario.Limonciello
2017-10-20 13:23 ` Greg KH
2017-10-20 14:15 ` Mario.Limonciello
2017-10-19 17:50 ` [PATCH v10 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-10-19 17:50 ` [PATCH v10 15/15] tools/wmi: add a sample for dell smbios communication over WMI Mario Limonciello
2017-11-09 9:52 ` [PATCH v10 00/15] Introduce support for Dell SMBIOS " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019180600.6gp7ch3z3bgbkqwt@pali \
--to=pali.rohar@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mjg59@google.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).