From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752892AbdJSSmb (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 14:42:31 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:45828 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751052AbdJSSm3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 14:42:29 -0400
X-Google-Smtp-Source: ABhQp+THDirr0FmELf+hRm0jLB0LS9SpAtn4nXi9XpNPWw4XVCNoc9zFWHw9XH5MCiggbgyz49KMFg==
Date: Thu, 19 Oct 2017 11:42:24 -0700
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: sboyd@codeaurora.org, pdeschrijver@nvidia.com,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-clk@vger.kernel.org, jonathanh@nvidia.com,
        mturquette@baylibre.com, pgaikwad@nvidia.com
Subject: Re: [PATCH v2] clk: tegra: Use readl_relaxed_poll_timeout_atomic in
 tegra210_clock_init
Message-ID: <20171019184223.GA7415@Asurada-Nvidia>
References: <1505502613-11801-1-git-send-email-nicoleotsuka@gmail.com>
 <20171019092919.GA7252@Asurada>
 <20171019094422.GI9005@ulmo>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171019094422.GI9005@ulmo>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 19, 2017 at 11:44:22AM +0200, Thierry Reding wrote:
> > > Below is the call trace of tegra210_init_pllu() function:
> > >   start_kernel()
> > >   -> time_init()
> > >   --> of_clk_init()
> > >   ---> tegra210_clock_init()
> > >   ----> tegra210_pll_init()
> > >   -----> tegra210_init_pllu()

> I'm wondering why we're not seeing a splat for this. Usually the kernel
> will warn if you sleep during atomic context. Does this mean we're just
> not hitting that case?

Yes.

> readx_poll_timeout() has a might_sleep_if(), and
> therefore it should always cause the splat.

That's true as long as CONFIG_DEBUG_ATOMIC_SLEEP is enabled locally.

> Any ideas why this has gone unnoticed for all this time?

We can see in the tegra210_init_pllu() function that it'll not call
tegra210_enable_pllu() if pllu is already enabled (by bootloader).

You can verify it by adding an irqs_disabled() in this routine. The
function is called during system-boot and suspend-n-resume. And both
cases should be irqs_disabled().

Thanks
Nicolin