From: Andi Kleen <ak@linux.intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Support resetting WARN*_ONCE
Date: Thu, 19 Oct 2017 13:47:06 -0700 [thread overview]
Message-ID: <20171019204706.GF5109@tassilo.jf.intel.com> (raw)
In-Reply-To: <87infdhvcd.fsf@concordia.ellerman.id.au>
On Wed, Oct 18, 2017 at 04:35:14PM +1100, Michael Ellerman wrote:
> Andi Kleen <andi@firstfloor.org> writes:
>
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > I like _ONCE warnings because it's guaranteed that they don't
> > flood the log.
> >
> > During testing I find it useful to reset the state of the once warnings,
> > so that I can rerun tests and see if they trigger again, or can
> > guarantee that a test run always hits the same warnings.
> >
> > This patch adds a debugfs interface to reset all the _ONCE
> > warnings so that they appear again:
> >
> > echo 1 > /sys/kernel/debug/clear_warn_once
> >
> > This is implemented by putting all the warning booleans into
> > a special section, and clearing it.
>
> That won't work for arches that do the ONCE logic with a flag will it?
> ie. arm64, parisc, powerpc, s390, sh, x86.
Thanks. I sent an incremential patch that fixes this.
-Andi
next prev parent reply other threads:[~2017-10-19 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 21:40 [PATCH] Support resetting WARN*_ONCE Andi Kleen
2017-10-17 21:54 ` Andrew Morton
2017-10-17 22:11 ` Andi Kleen
2017-10-18 5:35 ` Michael Ellerman
2017-10-19 20:47 ` Andi Kleen [this message]
2017-11-03 9:39 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2016-08-02 20:40 Andi Kleen
2016-08-03 4:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019204706.GF5109@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox