From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754383AbdJSUrJ (ORCPT ); Thu, 19 Oct 2017 16:47:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:63985 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbdJSUrI (ORCPT ); Thu, 19 Oct 2017 16:47:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,403,1503385200"; d="scan'208";a="162547460" Date: Thu, 19 Oct 2017 13:47:06 -0700 From: Andi Kleen To: Michael Ellerman Cc: Andi Kleen , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Support resetting WARN*_ONCE Message-ID: <20171019204706.GF5109@tassilo.jf.intel.com> References: <20171017214017.22708-1-andi@firstfloor.org> <87infdhvcd.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87infdhvcd.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 04:35:14PM +1100, Michael Ellerman wrote: > Andi Kleen writes: > > > From: Andi Kleen > > > > I like _ONCE warnings because it's guaranteed that they don't > > flood the log. > > > > During testing I find it useful to reset the state of the once warnings, > > so that I can rerun tests and see if they trigger again, or can > > guarantee that a test run always hits the same warnings. > > > > This patch adds a debugfs interface to reset all the _ONCE > > warnings so that they appear again: > > > > echo 1 > /sys/kernel/debug/clear_warn_once > > > > This is implemented by putting all the warning booleans into > > a special section, and clearing it. > > That won't work for arches that do the ONCE logic with a flag will it? > ie. arm64, parisc, powerpc, s390, sh, x86. Thanks. I sent an incremential patch that fixes this. -Andi