From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752117AbdJTHwf (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Oct 2017 03:52:35 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:47577 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751927AbdJTHwd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Oct 2017 03:52:33 -0400
Date: Fri, 20 Oct 2017 00:52:30 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Craig Gallek <cgallek@google.com>, Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timer: Provide wrappers safe for use with LOCKDEP
Message-ID: <20171020075230.GA31536@infradead.org>
References: <20171019202838.GA43223@beast>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171019202838.GA43223@beast>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 19, 2017 at 01:28:38PM -0700, Kees Cook wrote:
> Under LOCKDEP, the timer lock_class_key (set up in __setup_timer) needs
> to be tied to the caller's context, so an inline for timer_setup()
> won't work. We do, however, want to keep the inline version around for
> argument type checking, though, so this provides macro wrappers in the
> LOCKDEP case.

Heh, when I tried to do inline setup_timer Arnd had actually pointed
that out in the review..