From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <hpa@zytor.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bhe@redhat.com>,
<keescook@chromium.org>, <indou.takao@jp.fujitsu.com>,
<caoj.fnst@cn.fujitsu.com>
Subject: Re: [PATCH 1/4] kaslr: parse the extended movable_node=nn[KMG]@ss[KMG]
Date: Fri, 20 Oct 2017 17:34:22 +0800 [thread overview]
Message-ID: <20171020093421.GF5635@localhost.localdomain> (raw)
In-Reply-To: <804f8a19-f005-f6a5-0cf4-bd191ff01d37@cn.fujitsu.com>
On Fri, Oct 20, 2017 at 01:33:16PM +0800, Dou Liyang wrote:
>[...]
>> > > > >
>> > > > > +#ifdef CONFIG_MEMORY_HOTPLUG
>> > > > > +static void mem_mark_immovable(char *str)
>> > > > > +{
>> > > > > + int i = 0;
>> > > > > +
>> > > >
>> > > > you have use num_immovable_region, 'i' is useless. just remove it.
>> > >
>> > > Using num_immovable_region makes code too long. Using i will be
>> > > clear and make sure shoter than 80 characters.
>> >
>> > Oh, God, that's horrific. Did you find that your code is wrong?
>> >
>> > num_immovable_region will be reset each time.
>>
>> Did you test?
>>
>
>you can try with more than one movable_node, eg:
>
>"...movable_node=128G@128G movable_node=128G@256G..."
>
Yes, you are right.
I thought users will specify the regions like this:
movable_node=1G@2G,1G@4G
If users want to use
movable_node=1G@2G movable_node=1G@4G
Your suggestion is helpful and I will update it.
Thanks,
Chao Fan
>then, you will find the problem of you code.
>
>Thanks,
> dou
next prev parent reply other threads:[~2017-10-20 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 10:02 [PATCH 0/4] kaslr: extend movable_node to movable_node=nn[KMG]@ss[KMG] Chao Fan
2017-10-19 10:02 ` [PATCH 1/4] kaslr: parse the extended movable_node=nn[KMG]@ss[KMG] Chao Fan
2017-10-20 3:04 ` Dou Liyang
2017-10-20 3:22 ` Chao Fan
2017-10-20 3:41 ` Dou Liyang
2017-10-20 3:44 ` Chao Fan
2017-10-20 5:33 ` Dou Liyang
2017-10-20 9:34 ` Chao Fan [this message]
2017-10-19 10:02 ` [PATCH 2/4] kaslr: select the memory region in immovable node to process Chao Fan
2017-10-20 3:17 ` Dou Liyang
2017-10-20 3:41 ` Chao Fan
2017-10-20 6:05 ` Dou Liyang
2017-10-19 10:02 ` [PATCH 3/4] document: change the document for the extended movable_node Chao Fan
2017-10-19 10:02 ` [PATCH 4/4] kaslr: clean up a useless variable and some usless space Chao Fan
2017-10-20 3:19 ` Dou Liyang
2017-10-20 4:10 ` Chao Fan
2017-10-20 2:37 ` [PATCH 0/4] kaslr: extend movable_node to movable_node=nn[KMG]@ss[KMG] Dou Liyang
2017-10-20 2:53 ` Chao Fan
2017-10-20 3:37 ` Dou Liyang
2017-10-20 3:46 ` Chao Fan
2017-10-20 6:41 ` Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020093421.GF5635@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox