From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbdJTKoj (ORCPT ); Fri, 20 Oct 2017 06:44:39 -0400 Received: from mail-by2nam01on0080.outbound.protection.outlook.com ([104.47.34.80]:12983 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752688AbdJTKog (ORCPT ); Fri, 20 Oct 2017 06:44:36 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Vadim.Lomovtsev@cavium.com; Date: Fri, 20 Oct 2017 03:44:29 -0700 From: Vadim Lomovtsev To: Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, Wilson.Snyder@cavium.com, robert.richter@cavium.com, david.daney@cavium.com, mjaggi@caviumnetworks.com, Vadim Lomovtsev Subject: Re: [PATCH v7 0/2] PCI: quirks: Cavium ThunderX ACS quirk update Message-ID: <20171020104429.GA7898@localhost.localdomain> References: <1506536439-29318-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <1508244459-2615-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <20171019112645.GD6332@bhelgaas-glaptop.roam.corp.google.com> <20171019115921.GA6199@localhost.localdomain> <20171019185010.GE6332@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171019185010.GE6332@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: MWHPR15CA0056.namprd15.prod.outlook.com (10.174.254.18) To DM5PR07MB3002.namprd07.prod.outlook.com (10.172.87.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2137dd7-2249-4b1f-4026-08d517a78da5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:DM5PR07MB3002; X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3002;3:4ww9LduweK9vXUcLiQgO7E0oq6U99i4A5yvbXWa3ue7/GmloxGaJgGmbAEyNtbbOp7l8tPGijoni2OYYNnxLkfSpHtC2eUFLrr/k6rJiuLwwe5BI8p2NvrwVfTYnXXVVS+NMTCjqFPJ8+jj3QktTs5pVlm1RqNGfgrMW28vlTwpxJGMQPyA2zVHXwW2ZSzC1lBkEOPH4GG1Nht8/t+RssZIeRtykNZ6T3RZE/NFWBLvZtDHkbBHvMtjtXirzSTzs;25:NuBh1xibmyhWOgMjzMSxa/vqQ1qOJmpufIT48kVWi9vkscj5h+W46Lqvt+qY4h6ZhJOKzXnU2Ck4Vyhlb5wAk0HP0RDRU4iWwMDTAtC1NQDb3G40DskuN8ENieOPSNeDYy6Aqo3P/ArdUh3/4ljdMNd0435fq6lH/vZogugEmdnrUmIj/2A7gvsTRM6MH6ECVz8EDmAT+Ve8obftHkYYmnyXn0lpf3QIH8AmblI4pLZpYiw3g5tCwTb00KEZXotQEUnVjGeMa0AgVBy74gbQeyHNXeFDhQGtx139vYRbDe0SfLk21App1lDdzRaFeOAmniH0ncoBb3fRh0QmQ0Yd9Q==;31:8QOxQA3/Sp6+IxVNnJU+n1lj4djoeibZX0ANDVgrZ2ZKymzn/CUhSPBNRBfMGRMmS0MWC6Tj4mgVVXwUe+zZcaasEMshoxwdM8ef6CRWn53cavqSi5fM7riMi0lsbWJe2cryyn63GqSIbiWGruOcWxD2f7VjvKmv/ulF/et2t5Ze5LOwq4jkMCGh98qN7mc4FNrXL1ovGol0ucxntLjWgP7jOYcCmNnJPA3iCA5oIgA= X-MS-TrafficTypeDiagnostic: DM5PR07MB3002: X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3002;20:zOiai9OxOGlYKbfHSZRbQopk4pOdPizaVOUHEbmBB5GQbGTU3ZamtAIu3vSy380gWNm7gKvfJNLNUEfF2+55W+1raLvTjAkJsNYledLfYrYdbgyxlElmt4zjrmOynUMgO3X+l8WUKiuoeg8riFM9JDxIN/vO5T0EvuMV0gxprBOGV0W1VgKMLWWb0ZchEzZ4rsQV5nIb1zspFKqHn905NZoyJAxMdTLpF1pnmItbp7xVALjBDGy3j34bzFSn3m7q/JwiyY6YMK2WkM9BFlVdUvjeexSKZqlnaomX5kl2HttQi9uX4zoTKfKNhvZZ/zmQjXhj1JCvFFWnzojckLz3TKjl1/9GwIgOJrOnfiuPYLTqWcq56Pu3H//AbFtCT8crTqd5HUomJiSK1ji0Nx+kDdTCCm/abhUb94bajyLwM7aEztWGdwcYj7OFO1fjurBEcUYZ7hr8MFjsP8EJvMAYqpFrjKokpzmq4nzQJ1SK9TJz5JmajTCb6DdG7cCkBkCFyDXahhOZ7ZfitzKUSJ/YebYkdiObVVkTONaqO4MjZlHx3+avQALJrA95NdkrmrW8ffpVS/lbb5DmaYzkRf+sjwOOOArI1LhuiqcKspKFdbA=;4:m+AZj5XMPIA4IG2IZVN8DTQIyD9O89uglWgL6LxAwS5bkG32RXOYoc75ak8q7S+y65hOewN/pfU4q+dC5QmCFpuny9LbBooMtBpBhHkgr6MbTM5Ieys2m+1A3VS0QFYLZwdiZcqmHS8X+KDpEoSw/qIDVnzUj+28973mg/XgFz8ROuXlR9sI2AVikvKetHW5h1p07eazcNTVZ39dJH6iPiwMSfK7TpaqOipNVm+aifgwPhg5+Cyb09ktV9+EQM9sUATXSSMC3y3SElOqnA3B1koWIscJ3iM9mFhC5r7HSRGhOBl5nrkQ3e9qG4GSrlrF X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(788757137089); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(3231020)(10201501046)(100000703101)(100105400095)(93006095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR07MB3002;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR07MB3002; X-Forefront-PRVS: 0466CA5A45 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(376002)(346002)(54534003)(24454002)(52314003)(199003)(189002)(305945005)(97736004)(6246003)(7736002)(229853002)(54356999)(76176999)(50986999)(6666003)(101416001)(8676002)(107886003)(83506002)(16586007)(61506002)(72206003)(55016002)(9686003)(316002)(16526018)(66066001)(5660300001)(47776003)(478600001)(6506006)(53936002)(23726003)(1076002)(105586002)(189998001)(15650500001)(106356001)(50466002)(93886005)(33656002)(42882006)(6916009)(2950100002)(8936002)(4326008)(81156014)(58126008)(81166006)(2906002)(25786009)(6116002)(68736007)(3846002)(18370500001)(19627235001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB3002;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR07MB3002;23:6pLkMbIiVSgr3h0Tft7d4Go53180DEkZ38Amamx1K?= =?us-ascii?Q?3PEdtJKxBDu/3eUCsQWKzJyqnymIq6tiZSNUKlhZy1V4CFm9Czv9FR0s5yo9?= =?us-ascii?Q?WAv6EmR2JkTIdMPXGudNre+buJLJo1W17qo3HBGO1Ui7OE1w3tFhD13qr2Qp?= =?us-ascii?Q?6si9Sc4cNPT+CNNLXf2nS5eRSJJNUoC3TBvDfgwUFeMnal9GeQwto0Q026Ze?= =?us-ascii?Q?/+nbbvinFfi4lVtlbbam3fJvGOiMFbN5EPfpwxvGMbHNluBQ4BP+bCS1p4TZ?= =?us-ascii?Q?jKxzeQLbTzsuIGvlypOvW5qFJnE7StgN8pkdYEiTIthLJ0j1Aao+OUcf2f7h?= =?us-ascii?Q?MbYk+ReBbOkDJDxVV0KaRtOBJlmkyXveyMaby/4kNcotjt/obI1veSE7UzRZ?= =?us-ascii?Q?D45NJJpLatfI26WHp8FFLSUXKmFiplsDhemYa9N3Rbnf4JA3CB18Nwjiy9J6?= =?us-ascii?Q?lwN97ym9stoIy83XgjLkPZp6IyuVFYQepRYhie41oHBHSq8Eimm/ccDbtlZZ?= =?us-ascii?Q?te1ZKMnHdoeKa4hL9BzN/cLNh4tMIv7cOTHR42Vu1D7r+s3F9oFfNcR/AfhT?= =?us-ascii?Q?ZtBduVlcEWcKvdFrmAB4tb9WtQcKJO7PetvptGIcKtBTyrmZ/sHC0fGxLXq/?= =?us-ascii?Q?y1/ootyMDGZJwiKe4d3t/TsPYp65IMZ1vu+H2Isb0sAIsb0UHyDzQYJMEFAl?= =?us-ascii?Q?8XobqOZRfSfiWAm3Jd7YBZmc4q/80hYgZTmqbPvOJqRAqO8SGr7NW32k1qsb?= =?us-ascii?Q?5rh7Pp6lBPePlddGKEhY8JQ6Kp/Fc19vU1yZYUaf/Tq9dFw7mR7iWcjwjEvJ?= =?us-ascii?Q?F56xITV0qRW/U84WbCdgxfcQmlRGyWcu0/78ZDfRrbAY04iMeYqJhiN9xJCH?= =?us-ascii?Q?LpkKot58HaXNRqIkQP2b2Nd7/5x5BtdKzkKuN55l2SZe9p+5S+Tb463QNbwQ?= =?us-ascii?Q?LNsUhpxmseGZDiM8BtdkepakT7Eu6RyH8dt2Jc4KIYfRgidGi1NWaaNmKrYY?= =?us-ascii?Q?RAsR0Ft2JI4JPkG7kZMx1i7u5bZlnUQsCb7HE+DDYqQVQryCcSXdyByCU5v0?= =?us-ascii?Q?LKmg6Zu9SnrB4Gvfbuc8wZJp5dydtNNtKgkckcsRuX7rihMqjOos5OEt369s?= =?us-ascii?Q?eiGtI7pmYZ6nTlGjMfewwoVV4IIPGNWvURZohmcu63FiopxeK+8miJKPIlR/?= =?us-ascii?Q?lki0wXd53LdTdKlwt0/Gsi3oYnpuRfwIlqf4eNAEwLxC317qKSNDFKxTyJ5L?= =?us-ascii?Q?sPWWUj0rfcBWLZb8B2cxyLMgzJPy8GP/z61YGztrx+0RvWpHE6vUrNljbsPU?= =?us-ascii?Q?DdBuRUsMRg/TJT7wsovkQNatWdLnbpnHvJvUk08weRlMscoB/JHbozaAEQ6N?= =?us-ascii?Q?cw5Ng=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3002;6:uHa53S+WykXqTysBgkobpe61TTDqeuFzbh+gGZ4JZhCOAI+ERJirklclAGxh5zccgWy0Zm1Ztbld0UxgcH7adtSVbNJtOO1+ej9vjBF5YIlMAEHM4S9GJnYMoNAAGQXb0V7FqCgvii7HU3BkSxAFoIa+kqDivy0U1yKSQhDxnbKrfhfeNpkHm6UQfDvKdYH6QiiIHlx5Hp0ug99CKdffTmEZON2azvLQiNo+F6Uh7oMCDeZrgFdwAxEI/6xBkkSsBM71JHTfCcnocGi1gXH4NkwPWHs+yI7Br1mYhKwennpaIC57bU5jZFx+QW3dzDt0K3far7CWtvN/K2XpT5SBXw==;5:BzlQps4Ke9PMD1WJoKgspipgklueRWRuBtDWT8Y5Rsguoits4ij5Dq46cbicvSevqcAPLEtVyqTM4fd3+yeyVaoF4pe1vCwIrVZMWaUxiSqgwCjXe4IdHShbywFJ+R4pXxqvLDefEkoW80MuVHMckw==;24:UlJ2oI6ZtqWcJ8jtqi7alEsiY0PjLz9g6B9VX+AwSO/6IvD73zbKC4hskFHPn7ckiN4vD/1QtP2y/qAjwsL2M+t/plP4rTVZ/HNkqI2g8NI=;7:Vk+5+5H3lp6vGczzSGftRcUS5vNLsGu+mRaE+zcNFC65xn+nhYkTiWfOXlGjwee4eltIvwU3dqsjz0pGV/qEchtPvsIJb8OcZmQJCzOV4/ZHV7i7GkHzPUE56ooTUKZ95gHhLK+KGcX3MqzwNjGO2Dro2p6gYjtvzERc5zPovM4hOMApD5OJQs+RhG0L7ZpxdTOfx5STW9cmg9RaqKDTC4MaP+g1qXeJykc7pwWaV6c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2017 10:44:33.8531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2137dd7-2249-4b1f-4026-08d517a78da5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3002 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 01:50:10PM -0500, Bjorn Helgaas wrote: > On Thu, Oct 19, 2017 at 04:59:21AM -0700, Vadim Lomovtsev wrote: > > On Thu, Oct 19, 2017 at 06:26:45AM -0500, Bjorn Helgaas wrote: > > > On Tue, Oct 17, 2017 at 05:47:37AM -0700, Vadim Lomovtsev wrote: > > > > From: Vadim Lomovtsev > > > > > > > > version 7: > > > > - update patch description accordingly to review comments; > > > > - split for two patches: for ACS mask change and device id match change; > > > > - remove macro #define of ACS flags, put it back to quirk function; > > > > - remove '__inline_' from device id matching function; > > > > - wrap code comments to fit into 80 columns; > > > > - comment fix: change 0xa00 to 0xf800 for matching function description; > > > > > > > > version 6: > > > > - comment typo fix: change 0xa00 to 0xa000; > > > > > > > > version 5: > > > > - update code comments accordingly to review comments; > > > > > > > > version 4: > > > > - update ACS mask (remove TB and TD bits), update commit message (remove > > > > ACS register printout); > > > > > > > > version 3: > > > > - update subject: remove CN8XXX from subject line, replace it with ThunderX; > > > > > > > > version 2: > > > > - update match function in order to filter only ThunderX devices by device > > > > ids to properly filter CN8XXX devices, update subject & description with > > > > ACS register info (v2 was rejected by maillist due to triple X in subject); > > > > > > > > Vadim Lomovtsev (2): > > > > PCI: quirks: Set Cavium ACS capability quirk flags to assert > > > > RR/CR/SV/UF. > > > > PCI: quirks: Apply Cavium ThunderX ACS quirk only to Root Ports > > > > > > > > drivers/pci/quirks.c | 26 ++++++++++++++++++++------ > > > > 1 file changed, 20 insertions(+), 6 deletions(-) > > > > > > If I'm reading this correctly, the first patch is basically fixing a bug in > > > the original Cavium ACS quirk (b404bcfbf035 ("PCI: Add ACS quirk for all > > > Cavium devices")). Right? > > > > Yes, first patch fixes improper ACS flags in the patch you mentioned. > > > > The second one fixes devid check from another patch > > (b77d537d00d0 PCI: Apply Cavium ACS quirk only to CN81xx/CN83xx/CN88xx devices). > > > > > > > > I put them on pci/virtualization for v4.15 as follows (patches unchanged, > > > changelogs wordsmithed). > > > > > > > Good, thank you. > > > > > You mentioned stable backports. b404bcfbf035 ("PCI: Add ACS quirk for all > > > Cavium devices") appeared in v4.6. b77d537d00d0 ("PCI: Apply Cavium ACS > > > quirk only to CN81xx/CN83xx/CN88xx devices") appeared in v4.12. I assume > > > you would ideally want all this backported as far as v4.6? We'd have to > > > figure out how to express that in stable tags. > > > > Ideally yes, I think we would need to have them backported onto stable(s), > > but so far I didn't see any bug-reports which could require these fixes. > > > > Anyway, in term of backporting them - are there anything I can help with ? > > I added the following tags, which I *think* should be sufficient: > > PCI: Set Cavium ACS capability quirk flags to assert RR/CR/SV/UF > Cc: stable@vger.kernel.org # v4.6+: b77d537d00d0: PCI: Apply Cavium ACS quirk only to CN81xx/CN83xx/CN88xx devices > > PCI: Apply Cavium ThunderX ACS quirk to more Root Ports > Cc: stable@vger.kernel.org # v4.12+ Looks good. Thank you. -Vadim