From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: Johan Hovold <johan@kernel.org>, Jiri Slaby <jslaby@suse.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] serdev: ttyport: enforce tty-driver open() requirement
Date: Fri, 20 Oct 2017 14:21:44 +0200 [thread overview]
Message-ID: <20171020122144.GA30326@kroah.com> (raw)
In-Reply-To: <CAL_JsqKhCue-vMzM2ip3NoGTKb9T_EexG3G2-SekfVZOTKdHOA@mail.gmail.com>
On Tue, Oct 17, 2017 at 11:07:20AM -0500, Rob Herring wrote:
> On Mon, Oct 16, 2017 at 8:06 AM, Johan Hovold <johan@kernel.org> wrote:
> > The tty-driver open routine is mandatory, but the serdev
> > tty-port-controller implementation did not treat it as such and would
> > instead fall back to calling tty_port_open() directly.
>
> The idea was to eventually get rid of the tty_struct dependency and
> only depend on tty_port. That's very invasive though and needs various
> pieces of tty_struct to move into tty_port.
>
> Of course, tty_port_open itself would have to change as well, so this
> change doesn't really matter.
So are you acking these patches?
confused,
greg k-h
next prev parent reply other threads:[~2017-10-20 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 13:06 [PATCH 1/2] serdev: ttyport: enforce tty-driver open() requirement Johan Hovold
2017-10-16 13:06 ` [PATCH 2/2] serdev: ttyport: add missing open() error handling Johan Hovold
2017-10-17 16:08 ` Rob Herring
2017-10-18 7:01 ` Johan Hovold
2017-10-17 16:07 ` [PATCH 1/2] serdev: ttyport: enforce tty-driver open() requirement Rob Herring
2017-10-20 12:21 ` Greg Kroah-Hartman [this message]
2017-10-20 21:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020122144.GA30326@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox