From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbdJTMuh (ORCPT ); Fri, 20 Oct 2017 08:50:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59276 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbdJTMug (ORCPT ); Fri, 20 Oct 2017 08:50:36 -0400 Date: Fri, 20 Oct 2017 14:50:44 +0200 From: "gregkh@linuxfoundation.org" To: Stephen Hemminger Cc: "Stahl, Manuel" , "devel@driverdev.osuosl.org" , "hjk@linutronix.de" , "linux-kernel@vger.kernel.org" , "sojkam1@fel.cvut.cz" Subject: Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers Message-ID: <20171020125044.GA8634@kroah.com> References: <1507296707.2915.14.camel@iis-extern.fraunhofer.de> <1507296804.2915.16.camel@iis-extern.fraunhofer.de> <20171006134550.GA1626@kroah.com> <1507297826.2915.18.camel@iis-extern.fraunhofer.de> <20171006075700.587a5e22@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171006075700.587a5e22@xeon-e3> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote: > On Fri, 6 Oct 2017 13:50:44 +0000 > "Stahl, Manuel" wrote: > > > MSI(X) interrupts are not shared between devices. So when available > > those should be preferred over legacy interrupts. > > > > Signed-off-by: Manuel Stahl > > --- > >  drivers/uio/uio_pci_dmem_genirq.c | 27 ++++++++++++++++++++------- > >  drivers/uio/uio_pci_generic.c     | 24 ++++++++++++++++++------ > >  2 files changed, 38 insertions(+), 13 deletions(-) > > The last time I tried to do MSI-X with pci-generic it got rejected > by the maintainer. Hm, yeah, this would break users today that do not have msi-x, right? Not good, Manuel, how well did you test this? thanks, greg k-h