From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbdJTNXd (ORCPT ); Fri, 20 Oct 2017 09:23:33 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36967 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbdJTNXc (ORCPT ); Fri, 20 Oct 2017 09:23:32 -0400 X-ME-Sender: Date: Fri, 20 Oct 2017 15:23:40 +0200 From: Greg KH To: Mario Limonciello Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org, Andy Lutomirski , quasisec@google.com, pali.rohar@gmail.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, Alan Cox Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface for drivers Message-ID: <20171020132340.GC23973@kroah.com> References: <175838453318108ae69be344c4d3a2b75c2edc69.1508434514.git.mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <175838453318108ae69be344c4d3a2b75c2edc69.1508434514.git.mario.limonciello@dell.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote: > +#ifdef CONFIG_COMPAT > + .compat_ioctl = wmi_ioctl, Why do you still need a compat ioctl?