From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752258AbdJTPR4 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Oct 2017 11:17:56 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:56353 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751618AbdJTPRz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Oct 2017 11:17:55 -0400
X-Google-Smtp-Source: ABhQp+S6NOn4oaHlI7oiFnitMtiJ+jGRO9kgT+E6zACTBCNi6yThAxqM9EMC2a5pFSr5QYcewy0C3w==
Date: Fri, 20 Oct 2017 17:17:51 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Kees Cook <keescook@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Ian McDonald <ian.mcdonald@jandi.co.nz>,
        Vlad Yasevich <vyasevich@gmail.com>,
        Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs
Message-ID: <20171020151751.drjmkxkt2orbteag@gmail.com>
References: <150724519527.5014.10207042218696587159.stgit@devbox>
 <20171020122218.fwxtr5n2q7ixszpl@gmail.com>
 <CAGXu5j+2HniUKYeQpieCJs_z2i1qWA1HyKsaGi=qxGkRmfAU9Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAGXu5j+2HniUKYeQpieCJs_z2i1qWA1HyKsaGi=qxGkRmfAU9Q@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Kees Cook <keescook@chromium.org> wrote:

> On Fri, Oct 20, 2017 at 5:22 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > Ok, could we now also fix these:
> >
> > net/dccp/probe.c:166:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/dccp/probe.c:170:4: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/dccp/probe.c:190:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
> > drivers/misc/lkdtm_core.c:317:3: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
> > drivers/misc/lkdtm_core.c:322:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
> > drivers/misc/lkdtm_core.c:560:3: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/sctp/probe.c:189:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/sctp/probe.c:194:3: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/sctp/probe.c:240:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/ipv4/tcp_probe.c:280:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
> > net/ipv4/tcp_probe.c:298:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
> >
> > I'd suggest removing the networking ones and Cc:-ing it to the networking folks -
> > I strongly doubt anyone is using that functionality for real.
> >
> > The LKDTM one Kees had some ideas (patches?) for?
> 
> Oops, yes, I've sent this patch to Greg now. I had let it sit for a
> few days of 0-day testing and promptly forgot about it. ;)

Could we, as a special exception, carry this patch in -tip, so that the probes 
related changes stay togher - or is it too distruptive to the flow of other 
in-flight LKDTM patches, creating conflicts, etc.?

Thanks,

	Ingo