From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752419AbdJTPnI (ORCPT ); Fri, 20 Oct 2017 11:43:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:41866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbdJTPnH (ORCPT ); Fri, 20 Oct 2017 11:43:07 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD22A2190B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 20 Oct 2017 12:43:04 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Milian Wolff , jolsa@kernel.org, namhyung@kernel.org, Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v6 0/6] generate full callchain cursor entries for inlined frames Message-ID: <20171020154304.GF30002@kernel.org> References: <20171018185350.14893-1-milian.wolff@kdab.com> <87wp3sgjqo.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wp3sgjqo.fsf@linux.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 18, 2017 at 03:43:27PM -0700, Andi Kleen escreveu: > Milian Wolff writes: > > > This series of patches completely reworks the way inline frames are handled. > > Instead of querying for the inline nodes on-demand in the individual tools, > > we now create proper callchain nodes for inlined frames. The advantages this > > approach brings are numerous: > > Except for the comments on the one patch the other patches all look > good to me. I think I addressed this concern by always using absolute addresses, right? > Reviewed-by: Andi Kleen So I'm adding this to the patches, ok? - Arnaldo