From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753638AbdJTSGt (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Oct 2017 14:06:49 -0400
Received: from mga06.intel.com ([134.134.136.31]:46247 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753195AbdJTSGr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Oct 2017 14:06:47 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,408,1503385200"; 
   d="scan'208";a="1233267712"
Date: Fri, 20 Oct 2017 11:05:54 -0700
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>,
        Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, Adam Buchbinder <adam.buchbinder@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Qiaowei Ren <qiaowei.ren@intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kees Cook <keescook@chromium.org>,
        Thomas Garnier <thgarnie@google.com>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v9 13/29] x86/insn-eval: Add utility functions to get
 segment selector
Message-ID: <20171020180554.GB12298@voyager>
References: <1507770750.17492.34.camel@linux.intel.com>
 <20171012094833.xjk6jg5us3ffkih4@pd.tnic>
 <1507856897.17492.53.camel@linux.intel.com>
 <20171013113738.757ucfevds53eg6g@pd.tnic>
 <1507920223.17492.85.camel@linux.intel.com>
 <20171017093544.tjisbsbrag42egac@pd.tnic>
 <1508272312.17492.122.camel@linux.intel.com>
 <20171018202943.wbexbplzfxu3v5qf@pd.tnic>
 <20171019063054.GB20944@voyager>
 <20171020075540.zkhtqektg6xuxcqr@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171020075540.zkhtqektg6xuxcqr@pd.tnic>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 20, 2017 at 09:55:40AM +0200, Borislav Petkov wrote:
> On Wed, Oct 18, 2017 at 11:30:54PM -0700, Ricardo Neri wrote:
> > I saw that Documentation/process/email-clients.rst that emailed patches
> > should be in ASCII or UTF-8 encodings only, but my patch in UTF-8
> > causes problems. Then is UTF-8 not desirable?
> 
> Well, I don't think so even though I couldn't find anything that says so
> explicitly.
> 
> But I *think* source files' encoding should be ASCII, as otherwise even
> the tool patch barfs:
> 
>  patch: **** malformed patch at line 124:

I will stay away from UTF-8.

> 
> > Thanks for the detailed explanation and the pointers to fix the problem.
> > I am sorry for the inconvenience. Here is the patch again. I made sure
> > that it applies cleanly with git am and patch:
> 
> Yes, it looks good now:
> 
> Reviewed-by: Borislav Petkov <bp@suse.de>

Thank you!
> 
> ( ... or I've been staring definitely too long at this code and don't care
>   anymore :-)))

Your guidance definitely helped to make it more readable.

BR,
Ricardo