From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sherry Yang <sherryy@android.com>
Cc: linux-kernel@vger.kernel.org,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
maco@google.com, tkjos@google.com
Subject: Re: [PATCH v2 1/4] android: binder: Don't get mm from task
Date: Sat, 21 Oct 2017 10:15:13 +0200 [thread overview]
Message-ID: <20171021081513.GA19354@kroah.com> (raw)
In-Reply-To: <20171021005902.59586-2-sherryy@android.com>
On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote:
> Use binder_alloc struct's mm_struct rather than getting
> a reference to the mm struct through get_task_mm to
> avoid a potential deadlock between lru lock, task lock and
> dentry lock, since a thread can be holding the task lock
> and the dentry lock while trying to acquire the lru lock.
>
> Acked-by: Arve Hjønnevåg <arve@android.com>
> Signed-off-by: Sherry Yang <sherryy@android.com>
> ---
> drivers/android/binder_alloc.c | 22 +++++++++-------------
> drivers/android/binder_alloc.h | 1 -
> 2 files changed, 9 insertions(+), 14 deletions(-)
I've applied these first 2 patches, but patches 3 and 4 I have already
applied to my char-misc-next tree, right?
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-21 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 0:58 [PATCH v2 0/4] android: binder: fixes for memory allocator change Sherry Yang
2017-10-21 0:58 ` [PATCH v2 1/4] android: binder: Don't get mm from task Sherry Yang
2017-10-21 8:15 ` Greg Kroah-Hartman [this message]
2017-10-23 18:18 ` Arve Hjønnevåg
2017-10-24 7:28 ` Greg Kroah-Hartman
2017-10-24 18:36 ` Arve Hjønnevåg
2017-10-25 7:11 ` Greg Kroah-Hartman
2017-10-21 0:58 ` [PATCH v2 2/4] android: binder: Fix null ptr dereference in debug msg Sherry Yang
2017-10-21 0:59 ` [PATCH v2 3/4] android: binder: Remove unused vma argument Sherry Yang
2017-10-21 0:59 ` [PATCH v2 4/4] android: binder: Change binder_shrinker to static Sherry Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021081513.GA19354@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=riandrews@android.com \
--cc=sherryy@android.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox