From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932111AbdJULYw (ORCPT ); Sat, 21 Oct 2017 07:24:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:48341 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbdJULYv (ORCPT ); Sat, 21 Oct 2017 07:24:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,410,1503385200"; d="scan'208";a="165824825" Date: Sat, 21 Oct 2017 16:59:09 +0530 From: Vinod Koul To: Mark Brown Cc: Greg Kroah-Hartman , LKML , ALSA , Takashi , Pierre , Sanyog Kale , Shreyas NC , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi Subject: Re: [PATCH 02/14] soundwire: Add SoundWire bus type Message-ID: <20171021112909.GE30097@localhost> References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com> <1508382211-3154-3-git-send-email-vinod.koul@intel.com> <20171021090348.3wjl6nwoiklgdbrp@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171021090348.3wjl6nwoiklgdbrp@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 21, 2017 at 10:03:48AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > + ret = dev_pm_domain_attach(dev, false); > > + if (ret) { > > + dev_err(dev, "Failed to attach PM domain: %d\n", ret); > > + return ret; > > + } > > + > > + ret = drv->probe(slave, id); > > + if (ret) { > > + dev_err(dev, "Probe of %s failed: %d\n", drv->name, ret); > > + return ret; > > + } > > We don't detach the power domain if the probe fails. we should, thanks for spotting -- ~Vinod