From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753392AbdJULtT (ORCPT <rfc822;w@1wt.eu>);
        Sat, 21 Oct 2017 07:49:19 -0400
Received: from mga06.intel.com ([134.134.136.31]:21030 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753338AbdJULtS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 21 Oct 2017 07:49:18 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,410,1503385200"; 
   d="scan'208";a="325963502"
Date: Sat, 21 Oct 2017 17:23:35 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Takashi <tiwai@suse.de>,
        Pierre <pierre-louis.bossart@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        Shreyas NC <shreyas.nc@intel.com>, patches.audio@intel.com,
        alan@linux.intel.com, Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, srinivas.kandagatla@linaro.org,
        plai@codeaurora.org, Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties
Message-ID: <20171021115335.GJ30097@localhost>
References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com>
 <1508382211-3154-11-git-send-email-vinod.koul@intel.com>
 <20171021094253.45qbp6wzyhifw5vc@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171021094253.45qbp6wzyhifw5vc@sirena.org.uk>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 21, 2017 at 10:42:53AM +0100, Mark Brown wrote:
> On Thu, Oct 19, 2017 at 08:33:26AM +0530, Vinod Koul wrote:
> 
> > +static ssize_t clock_frequencies_show(struct sdw_bus *bus,
> > +			struct sdw_prop_attribute *attr, char *buf)
> > +{
> > +	ssize_t size = 0;
> > +	int i;
> > +
> > +	for (i = 0; i < bus->prop.num_freq; i++)
> > +		size += sprintf(buf + size, "%8d\n", bus->prop.freq[i]);
> > +
> > +	return size;
> > +}
> 
> sysfs is supposed to be one value per file...

I though it needs to be human readable like:

$ cat /sys/bus/cpu/devices/cpu0/cpufreq/scaling_available_governors
performance powersave

In this case, if this is allowed it does help to have a single file with all
supported frequencies for a device

> 
> > +int sdw_sysfs_slave_init(struct sdw_slave *slave)
> > +{
> > +	/* TODO: Initialize dp0 and dpn kobject and attribute */
> > +	return 0;
> > +}
> > +
> > +void sdw_sysfs_slave_exit(struct sdw_slave *slave)
> > +{
> > +}
> 
> Seems like an important TODO?

Yes. For now I will remove the dummy code and add the patches for this after
this series is done.

Thanks
-- 
~Vinod