From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbdJULuh (ORCPT ); Sat, 21 Oct 2017 07:50:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:45604 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753338AbdJULug (ORCPT ); Sat, 21 Oct 2017 07:50:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,410,1503385200"; d="scan'208";a="165340121" Date: Sat, 21 Oct 2017 17:24:54 +0530 From: Vinod Koul To: Mark Brown Cc: Greg Kroah-Hartman , LKML , ALSA , Takashi , Pierre , Sanyog Kale , Shreyas NC , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi Subject: Re: [PATCH 11/14] soundwire: cdns: Add cadence module Message-ID: <20171021115453.GK30097@localhost> References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com> <1508382211-3154-12-git-send-email-vinod.koul@intel.com> <20171021095201.cxxmgvliyzzr4ydo@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171021095201.cxxmgvliyzzr4ydo@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 21, 2017 at 10:52:01AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:27AM +0530, Vinod Koul wrote: > > > Cadence IP implements SoundWire Master. Add base cadence module > > initialization and interrupt handling > > It's probably worth saying something about how this isn't a device > driver but rather a library for device drivers. Yes you are right, I will update this to clarify > > > + if (int_status & CDNS_MCP_INT_CTRL_CLASH) { > > + > > + /* Slave is driving bit slot during control word */ > > + dev_err_ratelimited(cdns->dev, "Bus clash for control word\n"); > > + int_status |= CDNS_MCP_INT_CTRL_CLASH; > > + } > > So with this (and the other error flags) we check to see if the bit is > set, print an error and then set the bit we were looking for in the same > variable we just checked? no this doesnt look right, I will fix it up. -- ~Vinod