From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbdJUOKn (ORCPT ); Sat, 21 Oct 2017 10:10:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56322 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753362AbdJUOKl (ORCPT ); Sat, 21 Oct 2017 10:10:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AAA2860262 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Sat, 21 Oct 2017 07:10:38 -0700 From: Stephen Boyd To: Thierry Reding Cc: Michael Turquette , Timo Alho , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] clk: tegra: check BPMP response return code Message-ID: <20171021141038.GB15990@codeaurora.org> References: <6a69e270519fd1c7a12a335053bf59671abc3c4b.1504776489.git.talho@nvidia.com> <20171017103736.GA30589@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171017103736.GA30589@ulmo> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17, Thierry Reding wrote: > On Thu, Sep 07, 2017 at 12:31:02PM +0300, Timo Alho wrote: > > Check return code in BPMP response message(s). The typical error case > > is when clock operation is attempted with invalid clock identifier. > > > > Also remove error print from call to clk_get_info() as the > > implementation loops through range of all possible identifier, but the > > operation is expected error out when the clock id is unused. > > > > Signed-off-by: Timo Alho > > --- > > drivers/clk/tegra/clk-bpmp.c | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > Hi Mike, Stephen, > > do you mind if I pick this up into the Tegra tree? It has a build > dependency on patch 1/4. > > I only now realized that you guys weren't on Cc, hence quoting in > full. > No worries Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project