From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932173AbdJUPt4 (ORCPT ); Sat, 21 Oct 2017 11:49:56 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:52513 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139AbdJUPtz (ORCPT ); Sat, 21 Oct 2017 11:49:55 -0400 X-Google-Smtp-Source: ABhQp+SfikQfiR1kkMRrf7XbEml5abwNBg8/JAKxm8Y5RgVirzIcGBj/DoqVZKcO35PXvUQmAdHa9Q== Date: Sat, 21 Oct 2017 08:49:46 -0700 From: Tejun Heo To: Tal Shorer Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] workqueue: respect isolated cpus when queueing an unbound work Message-ID: <20171021154946.GL1302522@devbig577.frc2.facebook.com> References: <1508449446-23693-1-git-send-email-tal.shorer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508449446-23693-1-git-send-email-tal.shorer@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 20, 2017 at 12:44:06AM +0300, Tal Shorer wrote: > Initialize wq_unbound_cpumask to exclude cpus that were isolated by > the cmdline's isolcpus parameter. > > Signed-off-by: Tal Shorer > --- > kernel/workqueue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index ca937b0..25b351d 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -5546,7 +5546,7 @@ int __init workqueue_init_early(void) > WARN_ON(__alignof__(struct pool_workqueue) < __alignof__(long long)); > > BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL)); > - cpumask_copy(wq_unbound_cpumask, cpu_possible_mask); > + cpumask_andnot(wq_unbound_cpumask, cpu_possible_mask, cpu_isolated_map); Don't we also wanna apply the same masking when wq_unbound_cpumask is being updated after boot? Thanks. -- tejun