From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbdJWJa4 (ORCPT ); Mon, 23 Oct 2017 05:30:56 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37303 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdJWJaz (ORCPT ); Mon, 23 Oct 2017 05:30:55 -0400 Date: Mon, 23 Oct 2017 11:30:54 +0200 From: Pavel Machek To: Johan Hovold Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, cphealy@gmail.com, Lucas Stach , Nikita Yushchenko , Lee Jones , Greg Kroah-Hartman Subject: Re: [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory Processor Message-ID: <20171023093054.GG32228@amd> References: <20171013061321.31252-1-andrew.smirnov@gmail.com> <20171013061321.31252-2-andrew.smirnov@gmail.com> <20171013072731.GC29243@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5UGlQXeG3ziZS81+" Content-Disposition: inline In-Reply-To: <20171013072731.GC29243@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5UGlQXeG3ziZS81+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > drivers/platform/Kconfig | 2 + > > drivers/platform/Makefile | 1 + > > drivers/platform/rave/Kconfig | 26 ++ > > drivers/platform/rave/Makefile | 1 + > > drivers/platform/rave/rave-sp.c | 677 ++++++++++++++++++++++++++++++++= ++++++++ >=20 > First of all, why do these live in drivers/platform and why don't use > the mfd subsystem to implement this driver (instead of rolling your own > mfd-implementation)? Sending contributors around like this is quite uncool. 1st, it should not matter much in which directory the driver lives. 2nd, there's no reasonable way for contributor to proceed if he gets "stuck" between two maintainers. Can you discuss with MFD maintainers, and provide clear guidance? Thanks, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --5UGlQXeG3ziZS81+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlntts4ACgkQMOfwapXb+vIQDQCfVIjKVOuLq8fq2AIA09Mhuj2S H+cAnjsZAltC/k+t/c9cA7GUeSLnDccv =Clrm -----END PGP SIGNATURE----- --5UGlQXeG3ziZS81+--