From: Vinod Koul <vinod.koul@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
SF Markus Elfring <elfring@users.sourceforge.net>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Geliang Tang <geliangtang@gmail.com>,
Krister Johansen <kjlx@templeofstupid.com>,
Pan Bian <bianpan2016@163.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: ioat: Use common error handling code in ioat_xor_val_self_test()
Date: Mon, 23 Oct 2017 22:26:17 +0530 [thread overview]
Message-ID: <20171023165617.GK936@localhost> (raw)
In-Reply-To: <3e96d66a-de9c-5b2b-5646-84037a3935f7@intel.com>
On Mon, Oct 23, 2017 at 08:59:19AM -0700, Dave Jiang wrote:
> On 10/23/2017 12:27 AM, Dan Carpenter wrote:
> > These patches hurt readability.
> >
> > regards,
> > dan carpenter
> >
>
> I agree with Dan. I'm ok with not accepting this patch.
And I have no intention to :)
At least they should explain why or how it help, give the Coccinelle
scripts.. But sadly that is not done ...
--
~Vinod
next prev parent reply other threads:[~2017-10-23 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 15:34 [PATCH] dmaengine: ioat: Use common error handling code in ioat_xor_val_self_test() SF Markus Elfring
2017-10-23 7:27 ` Dan Carpenter
2017-10-23 15:59 ` Dave Jiang
2017-10-23 16:56 ` Vinod Koul [this message]
2017-10-23 17:39 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023165617.GK936@localhost \
--to=vinod.koul@intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=bianpan2016@163.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=elfring@users.sourceforge.net \
--cc=geliangtang@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox