From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751638AbdJWQv7 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 12:51:59 -0400
Received: from mga02.intel.com ([134.134.136.20]:50939 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751357AbdJWQv5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 12:51:57 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; 
   d="scan'208";a="326639178"
Date: Mon, 23 Oct 2017 22:26:17 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        SF Markus Elfring <elfring@users.sourceforge.net>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Geliang Tang <geliangtang@gmail.com>,
        Krister Johansen <kjlx@templeofstupid.com>,
        Pan Bian <bianpan2016@163.com>, LKML <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: ioat: Use common error handling code in
 ioat_xor_val_self_test()
Message-ID: <20171023165617.GK936@localhost>
References: <b28f440e-6d11-d37e-e5de-e6dfd6bce2e9@users.sourceforge.net>
 <20171023072745.nh2mrwez2to6nst4@mwanda>
 <3e96d66a-de9c-5b2b-5646-84037a3935f7@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3e96d66a-de9c-5b2b-5646-84037a3935f7@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 23, 2017 at 08:59:19AM -0700, Dave Jiang wrote:
> On 10/23/2017 12:27 AM, Dan Carpenter wrote:
> > These patches hurt readability.
> > 
> > regards,
> > dan carpenter
> > 
> 
> I agree with Dan. I'm ok with not accepting this patch.

And I have no intention to :)

At least they should explain why or how it help, give the Coccinelle
scripts.. But sadly that is not done ...

-- 
~Vinod