From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbdJXFkc (ORCPT ); Tue, 24 Oct 2017 01:40:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59524 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbdJXFk3 (ORCPT ); Tue, 24 Oct 2017 01:40:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7BD53624A8 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dyoung@redhat.com X-Mailbox-Line: From dyoung@redhat.com Tue Oct 24 13:39:01 2017 Message-Id: <20171024053901.813846011@redhat.com> User-Agent: quilt/0.65 Date: Tue, 24 Oct 2017 13:31:50 +0800 From: dyoung@redhat.com To: kexec@lists.infradead.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, bhe@redhat.com, vgoyal@redhat.com, yinghai@kernel.org, corbet@lwn.net, dyoung@redhat.com Subject: [PATCH 3/3] kdump: round up the total memory size to 128M for crashkernel reservation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline; filename=kdump-crashkernel-roundup-total-mem.patch X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 24 Oct 2017 05:40:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The total memory size we get in kernel is usually slightly less than 2G with a 2G memory module machine. The main reason is bios/firmware reserve some area it will not export all memory as usable to Linux. 2G memory X86 kvm guest test result of the total_mem value: UEFI boot with ovmf: 0x7ef10000 Legacy boot kvm guest: 0x7ff7cc00 An option is to use dmi/smbios to get physical memory size, but it's not reliable as well. According to Prarit hardware vendors sometimes screw this up. Thus we choose to round up total size to 128M to workaround this problem. This is a best effort workaround, will improve it when we have better way in the future. Signed-off-by: Dave Young --- kernel/crash_core.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) --- linux.orig/kernel/crash_core.c +++ linux/kernel/crash_core.c @@ -42,6 +42,15 @@ static int __init parse_crashkernel_mem( { char *cur = cmdline, *tmp; bool infinite_end = false; + unsigned long long total_mem = system_ram; + + /* + * Firmware usually reserves some memory regions for it's own use. + * so we get less than actual system memory size. + * We workaround this by round up the total size to 128M which is + * enough for most test cases. + */ + total_mem = roundup(total_mem, 0x8000000); /* for each entry of the comma-separated list */ do { @@ -86,13 +95,13 @@ static int __init parse_crashkernel_mem( return -EINVAL; } cur = tmp; - if (size >= system_ram) { + if (size >= total_mem) { pr_warn("crashkernel: invalid size\n"); return -EINVAL; } /* match ? */ - if (system_ram >= start && system_ram < end) { + if (total_mem >= start && total_mem < end) { *crash_size = size; if (end == ULLONG_MAX) infinite_end = true; @@ -126,9 +135,9 @@ static int __init parse_crashkernel_mem( pr_warn("Memory reservation scale order expected after '^'\n"); return -EINVAL; } - size = (system_ram - *crash_size) >> shift; + size = (total_mem - *crash_size) >> shift; size = *crash_size + roundup(size, 1ULL << 20); - if (size < system_ram) + if (size < total_mem) *crash_size = size; cur = tmp; } else