From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbdJXHRH (ORCPT ); Tue, 24 Oct 2017 03:17:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49712 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdJXHRD (ORCPT ); Tue, 24 Oct 2017 03:17:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E7138608 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Tue, 24 Oct 2017 09:16:59 +0200 From: Jiri Olsa To: "Jin, Yao" Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v5 2/6] perf record: Get the first sample time and last sample time Message-ID: <20171024071659.GB27972@krava> References: <1508542074-29483-1-git-send-email-yao.jin@linux.intel.com> <1508542074-29483-3-git-send-email-yao.jin@linux.intel.com> <20171023150436.GA10746@krava> <818cd5bf-fd40-444e-4f4d-c9e25cf90b51@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <818cd5bf-fd40-444e-4f4d-c9e25cf90b51@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 24 Oct 2017 07:17:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 10:03:05AM +0800, Jin, Yao wrote: SNIP > > hum, could you still unset the sample if there's no time given? > > and keep the speed in this case.. > > > > jirka > > > > Hi Jiri, > > I check this question again. The '--time' option is for perf report but not > for perf record. > > For perf record, we have to always walk on all samples to get the time of > first sample and the time of last sample whatever buildid_all is enabled or > not enabled. So 'rec->tool.sample = NULL' is removed. > > Sorry, the previous mail was replied at midnight, I was drowsy. :( > > If my answer is correct, I will not send v6. If my understanding is still > not correct, please let me know. right, I did not realize we store this unconditionaly.. then yes, it's ok I think I've already acked this, anyway for the patchset: Acked-by: Jiri Olsa thanks, jirka